From: Alexander Sergeyev <sergeev917@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Jeremy Szu <jeremy.szu@canonical.com>,
tiwai@suse.com,
"moderated list:SOUND" <alsa-devel@alsa-project.org>,
Kailang Yang <kailang@realtek.com>,
open list <linux-kernel@vger.kernel.org>,
Huacai Chen <chenhuacai@kernel.org>,
Jian-Hong Pan <jhp@endlessos.org>,
Hui Wang <hui.wang@canonical.com>, PeiSen Hou <pshou@realtek.com>
Subject: Re: [PATCH 1/4] ALSA: hda/realtek: fix mute/micmute LEDs for HP 855 G8
Date: Sat, 29 Jan 2022 17:47:04 +0300 [thread overview]
Message-ID: <20220129144704.xlmeylllvy3b3fum@localhost.localdomain> (raw)
In-Reply-To: <s5ho83yldu3.wl-tiwai@suse.de>
On Wed, Jan 26, 2022 at 04:24:36PM +0100, Takashi Iwai wrote:
> > Given that the CPU number is the same in alc_update_coefex_idx(), it seems
> > these calls execution is interrupted and interleaved on the same core.
> > And, actually, there are two LEDs to set (mute and micmute). Am I onto
> > something here?
> That's an interesting finding, and yes, such a race is quite
> possible. Below is a quick fix as an attempt to cover it.
> Could you give it a try?
Well, results are somewhat mixed.
With the supplied patch (with a mutex), the original fixup 91502a9a0b0d ("ALSA:
hda/realtek: fix speakers and micmute on HP 855 G8") is no longer needed for
speakers to work. So, the original timing issue is identified now.
But unbind-bind problems with IO_PAGE_FAULT and "out of range cmd" are not
eliminated. IO_PAGE_FAULT are often logged without accompanying "out of range
cmd". And after adding debugging printk() I haven't managed to trigger "out of
range cmd" yet. But IO_PAGE_FAULT are more easily triggered.
Are there ways to trace origins of IO_PAGE_FAULT itself?
next prev parent reply other threads:[~2022-01-29 14:41 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 17:03 Jeremy Szu
2021-05-19 17:03 ` [PATCH 2/4] ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Zbook G8 Jeremy Szu
2021-05-19 17:03 ` [PATCH 3/4] ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Zbook Fury 15 G8 Jeremy Szu
2021-05-19 17:03 ` [PATCH 4/4] ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Zbook Fury 17 G8 Jeremy Szu
2021-05-27 2:00 ` [PATCH 1/4] ALSA: hda/realtek: fix mute/micmute LEDs for HP 855 G8 Jeremy Szu
2021-05-27 6:14 ` Takashi Iwai
2022-01-11 19:52 ` Alexander Sergeyev
2022-01-12 9:45 ` Takashi Iwai
2022-01-12 10:12 ` Alexander Sergeyev
2022-01-12 10:13 ` Takashi Iwai
2022-01-12 10:48 ` Alexander Sergeyev
2022-01-12 20:18 ` Alexander Sergeyev
2022-01-13 7:14 ` Takashi Iwai
2022-01-13 18:31 ` Alexander Sergeyev
2022-01-13 21:19 ` Alexander Sergeyev
2022-01-14 16:37 ` Takashi Iwai
2022-01-14 18:37 ` Alexander Sergeyev
2022-01-15 7:55 ` Takashi Iwai
2022-01-15 15:22 ` Alexander Sergeyev
2022-01-19 9:12 ` Takashi Iwai
2022-01-19 9:32 ` Alexander Sergeyev
2022-01-22 19:05 ` Alexander Sergeyev
2022-01-22 20:56 ` Alexander Sergeyev
2022-01-26 15:24 ` Takashi Iwai
2022-01-29 14:47 ` Alexander Sergeyev [this message]
2022-01-30 11:10 ` Alexander Sergeyev
2022-01-31 14:57 ` Takashi Iwai
2022-02-05 15:00 ` Alexander Sergeyev
2022-02-05 17:51 ` Alexander Sergeyev
2022-02-07 14:21 ` Takashi Iwai
2022-02-08 19:49 ` Alexander Sergeyev
2022-02-08 14:36 ` Takashi Iwai
2022-02-08 19:52 ` Alexander Sergeyev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220129144704.xlmeylllvy3b3fum@localhost.localdomain \
--to=sergeev917@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=chenhuacai@kernel.org \
--cc=hui.wang@canonical.com \
--cc=jeremy.szu@canonical.com \
--cc=jhp@endlessos.org \
--cc=kailang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pshou@realtek.com \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®