From: Kees Cook <keescook@chromium.org>
To: Kees Cook <keescook@chromium.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Peter Rosin <peda@axentia.se>, Andy Shevchenko <andy@kernel.org>,
Matteo Croce <mcroce@microsoft.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
linux-hardening@vger.kernel.org
Subject: [PATCH] lib/test_string.c: Add test for strlen()
Date: Sun, 30 Jan 2022 10:36:53 -0800 [thread overview]
Message-ID: <20220130183653.491292-1-keescook@chromium.org> (raw)
Add a simple test for strlen() functionality, including using it as a
constant expression.
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Peter Rosin <peda@axentia.se>
Signed-off-by: Kees Cook <keescook@chromium.org>
---
I'll be taking this as part of my Clang FORTIFY_SOURCE series.
---
lib/test_string.c | 37 +++++++++++++++++++++++++++++++++++++
1 file changed, 37 insertions(+)
diff --git a/lib/test_string.c b/lib/test_string.c
index 9dfd6f52de92..59994f552c48 100644
--- a/lib/test_string.c
+++ b/lib/test_string.c
@@ -179,6 +179,38 @@ static __init int strnchr_selftest(void)
return 0;
}
+/*
+ * Unlike many other string functions, strlen() can be used in
+ * static initializers when string lengths are known at compile
+ * time. (i.e. Under these conditions, strlen() is a constant
+ * expression.) Make sure it can be used this way.
+ */
+static const int strlen_ce = strlen("tada, a constant expression");
+
+static __init int strlen_selftest(void)
+{
+ /* String length ruler: 123456789012345 */
+ static const char normal[] = "I am normal";
+ static const char *ptr = "where do I go?";
+ static const char trailing[] = "hidden NULLs\0\0\0";
+ static const char leading[] = "\0\0hidden text";
+
+ if (strlen(normal) != 11)
+ return 0x100001;
+ if (strlen(ptr++) != 14)
+ return 0x100002;
+ if (strlen(ptr++) != 13)
+ return 0x100003;
+ if (strlen(trailing) != 12)
+ return 0x100004;
+ if (strlen(leading) != 0)
+ return 0x100005;
+ if (strlen_ce != 27)
+ return 0x100006;
+
+ return 0;
+}
+
static __exit void string_selftest_remove(void)
{
}
@@ -212,6 +244,11 @@ static __init int string_selftest_init(void)
if (subtest)
goto fail;
+ test = 5;
+ subtest = strlen_selftest();
+ if (subtest)
+ goto fail;
+
pr_info("String selftests succeeded\n");
return 0;
fail:
--
2.30.2
next reply other threads:[~2022-01-30 18:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-30 18:36 Kees Cook [this message]
2022-01-30 18:56 ` Andy Shevchenko
2022-01-30 20:34 ` Kees Cook
2022-01-30 20:13 ` kernel test robot
2022-01-30 20:35 ` Kees Cook
2022-02-02 16:01 ` Guenter Roeck
2022-02-02 16:16 ` Andy Shevchenko
2022-02-02 20:52 ` Kees Cook
2022-02-02 23:12 ` Guenter Roeck
2022-02-03 8:04 ` Geert Uytterhoeven
2022-02-03 16:41 ` Kees Cook
2022-02-03 17:15 ` Kees Cook
2022-02-03 18:09 ` Geert Uytterhoeven
2022-02-03 19:50 ` Nick Desaulniers
2022-02-03 20:25 ` Kees Cook
2022-02-03 20:45 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220130183653.491292-1-keescook@chromium.org \
--to=keescook@chromium.org \
--cc=andy@kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mcroce@microsoft.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=peda@axentia.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®