From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5310C433F5 for ; Mon, 31 Jan 2022 23:44:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229764AbiAaXoP (ORCPT ); Mon, 31 Jan 2022 18:44:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229771AbiAaXoC (ORCPT ); Mon, 31 Jan 2022 18:44:02 -0500 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49549C06173D for ; Mon, 31 Jan 2022 15:44:02 -0800 (PST) Received: by mail-lf1-x135.google.com with SMTP id f10so3724836lfu.8 for ; Mon, 31 Jan 2022 15:44:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+h8DeuUfkcjLos3BviUGDVOpxtzirtyuHipEzyipWwg=; b=LEHAp+tjvjupiksn3rRU+MTYTYJP1zmZug2s1ZZldzoTJGpYo9m+xIPjubK2rtcde8 GPVx0URubvo/jJvle5RTJhnlLC6JqkPwVNpFtC6I83045f95Guvh3joXjYsjHykGAlhq 92OP3IdGZsIVkSJitzv8T5+TJfntyXg5hJSlvUP6BKmhR65VEndbO031zvU3CMnXmYk9 37chJ05w0IkvWVqNAA3kZqvLNIDXrV27x1B83Wu+CnJ9lk9O+BCi95z2rkMNtZXgJub7 vR4PpZz9noMFzfCD8iynifIes6TpoGPVFMyIInGkSWaFrJWp7gVEPpedEqol12ZjoTY0 Ef8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+h8DeuUfkcjLos3BviUGDVOpxtzirtyuHipEzyipWwg=; b=cKCXETWvMK/sgyEgIKB5zochOnP82ubihuEq0DgzWFOwDq6f/65E2ZdItH2QCwSSwl B6G2gwppEYya1lDW2KLh3P/wnvCXcMV1wFR73sScSDcqfMnAllNShPNuC/Aq3uuvEclh fiR8RJl3w0ZoSbYWamKXwUqi3cmeZ5jgQGp/6fkM4YeJbvFpor/k1LF0v73+odfLRYvi AysSKLWM541Zmw9w4BdiVOqvoh9CL7IMLrIY7fuNUnDRrVi4Uq9eO1bVMxHolXR127o2 w8YD7NJ+pv5QJ1yw1bJsagBAP98JeWtDUIltWV6F8Hfv9qxgDt60so6/YXztXDv9qXX8 jKEg== X-Gm-Message-State: AOAM532Q6uEVEFDMsi8JxUSMWa+qLqH4a7YfshmOYpr29ZIs7ygMGr9T MJ96gECimkwonr2EC1pY4DNcxA== X-Google-Smtp-Source: ABdhPJy9muQCEl5VEBzDXlXUJUJcCiNqcoX+SUeTK/d+sBX/xKeTfWiTXJNIQJsO4DDl7bWle3JZBg== X-Received: by 2002:a05:6512:1116:: with SMTP id l22mr16771617lfg.219.1643672640599; Mon, 31 Jan 2022 15:44:00 -0800 (PST) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id m12sm3812652lfj.90.2022.01.31.15.43.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 15:43:59 -0800 (PST) Received: by box.localdomain (Postfix, from userid 1000) id 5452110458C; Tue, 1 Feb 2022 02:44:37 +0300 (+03) Date: Tue, 1 Feb 2022 02:44:37 +0300 From: "Kirill A. Shutemov" To: Dave Hansen Cc: "Kirill A. Shutemov" , Borislav Petkov , Andy Lutomirski , Sean Christopherson , Andrew Morton , Joerg Roedel , Ard Biesheuvel , Andi Kleen , Kuppuswamy Sathyanarayanan , David Rientjes , Vlastimil Babka , Tom Lendacky , Thomas Gleixner , Peter Zijlstra , Paolo Bonzini , Ingo Molnar , Varad Gautam , Dario Faggioli , Brijesh Singh , Mike Rapoport , David Hildenbrand , x86@kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv3 2/7] efi/x86: Get full memory map in allocate_e820() Message-ID: <20220131234437.twazkxvsdukhq2xs@box.shutemov.name> References: <20220128205906.27503-1-kirill.shutemov@linux.intel.com> <20220128205906.27503-3-kirill.shutemov@linux.intel.com> <101a4497-ae17-ab69-640d-667c79da639b@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <101a4497-ae17-ab69-640d-667c79da639b@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 31, 2022 at 02:38:42PM -0800, Dave Hansen wrote: > On 1/28/22 12:59, Kirill A. Shutemov wrote: > > Modify allocate_e820() to get a full memory map. > > Dumb question time: why doesn't the current code get a full memory map? > This looks simpler. What's the downside? Memory consumption? Yeah, it requires memory allocation that has to be freed back. Otherwise I don't see any downsides. There are several more EFI calls, but it should not make a noticable difference on boot time. -- Kirill A. Shutemov