From: "Paul E. McKenney" <paulmck@kernel.org>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: jiangshanlai@gmail.com, josh@joshtriplett.org,
rostedt@goodmis.org, mathieu.desnoyers@efficios.com,
rcu@vger.kernel.org, linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] srcu: make srcu_size_state_name static
Date: Tue, 1 Feb 2022 11:23:50 -0800 [thread overview]
Message-ID: <20220201192350.GE4285@paulmck-ThinkPad-P17-Gen-1> (raw)
In-Reply-To: <20220129034502.73912-1-jiapeng.chong@linux.alibaba.com>
On Sat, Jan 29, 2022 at 11:45:02AM +0800, Jiapeng Chong wrote:
> This symbol is not used outside of srcutree.c, so marks it static.
>
> Fixes the following sparse warning:
>
> kernel/rcu/srcutree.c:1426:12: warning: symbol 'srcu_size_state_name'
> was not declared. Should it be static?
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
And I did queue and push this, good catch, thank you!
Thanx, Paul
> ---
> kernel/rcu/srcutree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/rcu/srcutree.c b/kernel/rcu/srcutree.c
> index 4201815744d8..31dbd41332f6 100644
> --- a/kernel/rcu/srcutree.c
> +++ b/kernel/rcu/srcutree.c
> @@ -1423,7 +1423,7 @@ void srcutorture_get_gp_data(enum rcutorture_type test_type,
> }
> EXPORT_SYMBOL_GPL(srcutorture_get_gp_data);
>
> -const char * const srcu_size_state_name[] =
> +static const char * const srcu_size_state_name[] =
> {
> "SRCU_SIZE_SMALL",
> "SRCU_SIZE_ALLOC",
> --
> 2.20.1.7.g153144c
>
prev parent reply other threads:[~2022-02-01 19:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-29 3:45 Jiapeng Chong
2022-02-01 19:23 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220201192350.GE4285@paulmck-ThinkPad-P17-Gen-1 \
--to=paulmck@kernel.org \
--cc=abaci@linux.alibaba.com \
--cc=jiangshanlai@gmail.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®