From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D11BC433FE for ; Wed, 2 Feb 2022 09:39:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245528AbiBBJjI (ORCPT ); Wed, 2 Feb 2022 04:39:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244735AbiBBJjC (ORCPT ); Wed, 2 Feb 2022 04:39:02 -0500 Received: from relay08.th.seeweb.it (relay08.th.seeweb.it [IPv6:2001:4b7a:2000:18::169]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4065BC061714 for ; Wed, 2 Feb 2022 01:39:02 -0800 (PST) Received: from SoMainline.org (94-209-165-62.cable.dynamic.v4.ziggo.nl [94.209.165.62]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 4E4443F6FA; Wed, 2 Feb 2022 10:39:00 +0100 (CET) Date: Wed, 2 Feb 2022 10:38:58 +0100 From: Marijn Suijten To: phone-devel@vger.kernel.org, Rob Herring Cc: Marijn Suijten , linux-kernel@vger.kernel.org, Amit Pundir , Greg Kroah-Hartman , John Stultz Subject: Re: [PATCH 2/2] config: android-recommended: Disable BPF_UNPRIV_DEFAULT_OFF for netd Message-ID: <20220202093858.cmkm2z5w2fum6jit@SoMainline.org> Mail-Followup-To: Marijn Suijten , phone-devel@vger.kernel.org, Rob Herring , Marijn Suijten , linux-kernel@vger.kernel.org, Amit Pundir , Greg Kroah-Hartman , John Stultz References: <20220202093355.108460-2-marijn.suijten@somainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220202093355.108460-2-marijn.suijten@somainline.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-02-02 10:33:55, Marijn Suijten wrote: > From: Marijn Suijten Feel free to disregard this `From:` override, didn't catch it when preparing the patches from a different machine. - Marijn > AOSP's `netd` process fails to start on Android S: > > E ClatdController: getClatEgress4MapFd() failure: Operation not permitted > I netd : Initializing ClatdController: 410us > E netd : Failed to start trafficcontroller: (Status[code: 1, msg: "Pinned map not accessible or does not exist: (/sys/fs/bpf/map_netd_cookie_tag_map): Operation not permitted"]) > E netd : CRITICAL: sleeping 60 seconds, netd exiting with failure, crash loop likely! > > And on Android R: > > I ClatdController: 4.9+ kernel and device shipped with P - clat ebpf might work. > E ClatdController: getClatEgressMapFd() failure: Operation not permitted > I netd : Initializing ClatdController: 1409us > E netd : Failed to start trafficcontroller: (Status[code: 1, msg: "Pinned map not accessible or does not exist: (/sys/fs/bpf/map_netd_cookie_tag_map): Operation not permitted"]) > > These permission issues are caused by 08389d888287 ("bpf: Add kconfig > knob for disabling unpriv bpf by default") because AOSP does not provide > netd the `SYS_ADMIN` capability, and also has no userspace support for > the `BPF` capability yet. > > Cc: Amit Pundir > Cc: Greg Kroah-Hartman > Suggested-by: John Stultz > [John suggested this in https://linaro.atlassian.net/browse/ACK-107?focusedCommentId=117382] > Signed-off-by: Marijn Suijten > --- > kernel/configs/android-recommended.config | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/configs/android-recommended.config b/kernel/configs/android-recommended.config > index 22bd76e43aca..e400fbbc8aba 100644 > --- a/kernel/configs/android-recommended.config > +++ b/kernel/configs/android-recommended.config > @@ -1,4 +1,5 @@ > # KEEP ALPHABETICALLY SORTED > +# CONFIG_BPF_UNPRIV_DEFAULT_OFF is not set > # CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS is not set > # CONFIG_INPUT_MOUSE is not set > # CONFIG_LEGACY_PTYS is not set > -- > 2.35.1 >