From: Douglas Anderson <dianders@chromium.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: pmaliset@codeaurora.org, mka@chromium.org,
quic_rjendra@quicinc.com,
Shaik Sajida Bhanu <sbhanu@codeaurora.org>,
kgodara@codeaurora.org, konrad.dybcio@somainline.org,
Sankeerth Billakanti <quic_sbillaka@quicinc.com>,
sibis@codeaurora.org, swboyd@chromium.org,
Douglas Anderson <dianders@chromium.org>,
Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v3 09/14] arm64: dts: qcom: sc7280: Disable pull from pcie1_clkreq
Date: Wed, 2 Feb 2022 13:23:43 -0800 [thread overview]
Message-ID: <20220202132301.v3.9.I5f367dcce8107f2186b2aad4aef0dfcfafa034b9@changeid> (raw)
In-Reply-To: <20220202212348.1391534-1-dianders@chromium.org>
I believe that the PCIe clkreq pin is an output. That means we
shouldn't have a pull enabled for it. Turn it off.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
Changes in v3:
- ("sc7280-idp: Disable pull from pcie1_clkreq") new for v3.
arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r0.dts | 2 +-
arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r0.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r0.dts
index 82c3c8f0342b..3c5aab225748 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r0.dts
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r0.dts
@@ -827,7 +827,7 @@ &usb_2_hsphy {
/* PINCTRL - additions to nodes defined in sc7280.dtsi */
&pcie1_clkreq_n {
- bias-pull-up;
+ bias-disable;
drive-strength = <2>;
};
diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
index 6e20e8c07402..9140dca3b72a 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
@@ -367,7 +367,7 @@ key_vol_up_default: key-vol-up-default {
};
&pcie1_clkreq_n {
- bias-pull-up;
+ bias-disable;
drive-strength = <2>;
};
--
2.35.0.rc2.247.g8bbb082509-goog
next prev parent reply other threads:[~2022-02-02 21:25 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 21:23 [PATCH v3 00/14] arm64: dts: qcom: sc7x80: A smattering of misc dts cleanups + herobrine-rev1 Douglas Anderson
2022-02-02 21:23 ` [PATCH v3 01/14] arm64: dts: qcom: sc7180-trogdor: Add "-regulator" suffix to pp3300_hub Douglas Anderson
2022-02-03 21:24 ` Stephen Boyd
2022-02-02 21:23 ` [PATCH v3 02/14] arm64: dts: qcom: sc7280-herobrine: Consistently add "-regulator" suffix Douglas Anderson
2022-02-03 21:24 ` Stephen Boyd
2022-02-02 21:23 ` [PATCH v3 03/14] arm64: dts: qcom: sc7280: Properly sort sdc pinctrl lines Douglas Anderson
2022-02-03 21:24 ` Stephen Boyd
2022-02-02 21:23 ` [PATCH v3 04/14] arm64: dts: qcom: sc7280: Clean up sdc1 / sdc2 pinctrl Douglas Anderson
2022-02-02 22:42 ` Matthias Kaehlcke
2022-02-03 21:28 ` Stephen Boyd
2022-02-02 21:23 ` [PATCH v3 05/14] arm64: dts: qcom: sc7280-idp: No need for "input-enable" on sw_ctrl Douglas Anderson
2022-02-03 21:28 ` Stephen Boyd
2022-02-02 21:23 ` [PATCH v3 06/14] arm64: dts: qcom: sc7280: Fix sort order of dp_hot_plug_det / pcie1_clkreq_n Douglas Anderson
2022-02-02 22:45 ` Matthias Kaehlcke
2022-02-03 21:28 ` Stephen Boyd
2022-02-02 21:23 ` [PATCH v3 07/14] arm64: dts: qcom: sc7280: Add edp_out port and HPD lines Douglas Anderson
2022-02-02 22:51 ` Matthias Kaehlcke
2022-02-03 21:30 ` Stephen Boyd
2022-02-02 21:23 ` [PATCH v3 08/14] arm64: dts: qcom: sc7280: Move pcie1_clkreq pull / drive str to boards Douglas Anderson
2022-02-03 17:07 ` Matthias Kaehlcke
2022-02-03 21:30 ` Stephen Boyd
2022-02-02 21:23 ` Douglas Anderson [this message]
2022-02-03 17:20 ` [PATCH v3 09/14] arm64: dts: qcom: sc7280: Disable pull from pcie1_clkreq Matthias Kaehlcke
2022-02-03 21:42 ` Stephen Boyd
2022-02-03 21:53 ` Doug Anderson
2022-02-03 21:59 ` Stephen Boyd
2022-02-03 23:42 ` Doug Anderson
2022-02-02 21:23 ` [PATCH v3 10/14] arm64: dts: qcom: sc7280: Move dp_hot_plug_det pull from SoC dtsi file Douglas Anderson
2022-02-03 17:22 ` Matthias Kaehlcke
2022-02-03 21:42 ` Stephen Boyd
2022-02-02 21:23 ` [PATCH v3 11/14] arm64: dts: qcom: sc7280: Add a blank line in the dp node Douglas Anderson
2022-02-03 17:26 ` Matthias Kaehlcke
2022-02-03 21:42 ` Stephen Boyd
2022-02-02 21:23 ` [PATCH v3 12/14] arm64: dts: qcom: sc7280: Add herobrine-r1 Douglas Anderson
2022-02-03 18:05 ` Matthias Kaehlcke
2022-02-03 23:26 ` Doug Anderson
2022-02-04 22:14 ` Doug Anderson
2022-02-02 21:23 ` [PATCH v3 13/14] arm64: dts: qcom: sc7280: Add the CPU compatible to the soc@0 node Douglas Anderson
2022-02-03 21:44 ` Stephen Boyd
2022-02-04 21:51 ` Bjorn Andersson
2022-02-05 2:59 ` Stephen Boyd
2022-02-02 21:23 ` [PATCH v3 14/14] arm64: dts: qcom: sc7280: Remove "qcom,sc7280" from top-level of boards Douglas Anderson
2022-02-03 21:45 ` Stephen Boyd
2022-02-04 21:54 ` (subset) [PATCH v3 00/14] arm64: dts: qcom: sc7x80: A smattering of misc dts cleanups + herobrine-rev1 Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220202132301.v3.9.I5f367dcce8107f2186b2aad4aef0dfcfafa034b9@changeid \
--to=dianders@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kgodara@codeaurora.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=pmaliset@codeaurora.org \
--cc=quic_rjendra@quicinc.com \
--cc=quic_sbillaka@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sbhanu@codeaurora.org \
--cc=sibis@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®