mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Armin Wolf <W_Armin@gmx.de>,
	jdelvare@suse.com, linux-hwmon@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/4] hwmon: (sch56xx) Automatically load on supported hardware
Date: Wed, 2 Feb 2022 17:06:33 -0800	[thread overview]
Message-ID: <20220203010633.GA2544812@roeck-us.net> (raw)
In-Reply-To: <01e51bfa-5107-fbd0-6a0b-82bca6c78e8e@redhat.com>

On Tue, Feb 01, 2022 at 01:57:02PM +0100, Hans de Goede wrote:
> Hi,
> 
> On 1/31/22 22:19, Armin Wolf wrote:
> > The hardware monitoring solutions supported by the sch5627 and
> > sch5636 drivers are Fujitsu-specific.
> > After some online searching, i found out that the solution used
> > with the SCH5627 is called "Antiope" by Fujitsu, just like the
> > "Theseus" solution inside the SCH5636.
> > I also found out that "Antiope" and "Theseus" are listed as
> > DMI onboard devices on supported Fujitsu devices, so the
> > sch56xx_common module can be loaded automatically an check
> > for the DMI devices. However some devices like the Esprimo C700
> > have both devices, so after verifying that at least one onboard
> > device is present, sch56xx_common still has to detect which chip
> > is present.
> > This is safe however if at least one device is present.
> > 
> > Tested on a Fujitsu Esprimo P720.
> 
> Thanks, the new version of the entire series looks good to me:
> 
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> 

Series applied.

Thanks,
Guenter

      reply	other threads:[~2022-02-03  1:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-31 21:19 Armin Wolf
2022-01-31 21:19 ` [PATCH v3 1/4] hwmon: (sch56xx) Autoload modules on platform device creation Armin Wolf
2022-01-31 21:19 ` [PATCH v3 2/4] hwmon: (sch56xx-common) Add automatic module loading on supported devices Armin Wolf
2022-01-31 21:19 ` [PATCH v3 3/4] hwmon: (sch56xx-common) Replace msleep() with usleep_range() Armin Wolf
2022-01-31 21:19 ` [PATCH v3 4/4] hwmon: (sch56xx-common) Replace WDOG_ACTIVE with WDOG_HW_RUNNING Armin Wolf
2022-02-01 12:57 ` [PATCH v3 0/4] hwmon: (sch56xx) Automatically load on supported hardware Hans de Goede
2022-02-03  1:06   ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220203010633.GA2544812@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=W_Armin@gmx.de \
    --cc=hdegoede@redhat.com \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®