mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lukasz Luba <lukasz.luba@arm.com>
To: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Cc: amit.kachhap@gmail.com, daniel.lezcano@linaro.org,
	viresh.kumar@linaro.org, rafael@kernel.org, amitk@kernel.org,
	rui.zhang@intel.com, dietmar.eggemann@arm.com,
	lukasz.luba@arm.com, Pierre.Gondois@arm.com
Subject: [PATCH 2/2] powercap: DTPM: Check Energy Model type for power values scale
Date: Mon,  7 Feb 2022 07:30:36 +0000	[thread overview]
Message-ID: <20220207073036.14901-3-lukasz.luba@arm.com> (raw)
In-Reply-To: <20220207073036.14901-1-lukasz.luba@arm.com>

The Energy Model power values might be in an abstract scale. In such case
it's safe to bail out during the registration, since the PowerCap
framework supports only micro-Watts.

Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
---
 drivers/powercap/dtpm_cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/powercap/dtpm_cpu.c b/drivers/powercap/dtpm_cpu.c
index b740866b228d..e6bcde081de4 100644
--- a/drivers/powercap/dtpm_cpu.c
+++ b/drivers/powercap/dtpm_cpu.c
@@ -188,7 +188,7 @@ static int cpuhp_dtpm_cpu_online(unsigned int cpu)
 		return 0;
 
 	pd = em_cpu_get(cpu);
-	if (!pd)
+	if (!pd || !(pd->flags & EM_PERF_DOMAIN_MILLIWATTS))
 		return -EINVAL;
 
 	dtpm_cpu = per_cpu(dtpm_per_cpu, cpu);
-- 
2.17.1


  parent reply	other threads:[~2022-02-07  7:44 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-07  7:30 [PATCH 0/2] Ignore Energy Model with abstract scale in IPA and DTPM Lukasz Luba
2022-02-07  7:30 ` [PATCH 1/2] thermal: cooling: Check Energy Model type in cpufreq_cooling and devfreq_cooling Lukasz Luba
2022-02-08  0:50   ` Matthias Kaehlcke
2022-02-08  9:32     ` Lukasz Luba
2022-02-08 17:25       ` Matthias Kaehlcke
2022-02-09 11:16         ` Lukasz Luba
2022-02-09 22:17           ` Matthias Kaehlcke
2022-02-16 15:35             ` Lukasz Luba
2022-02-16 17:33               ` Doug Anderson
2022-02-16 22:13                 ` Matthias Kaehlcke
2022-02-16 22:43                   ` Lukasz Luba
2022-02-17  0:26                     ` Matthias Kaehlcke
2022-02-17 10:15                     ` Daniel Lezcano
2022-02-17  9:59                   ` Daniel Lezcano
2022-02-17 10:10                 ` Daniel Lezcano
2022-02-17 10:47                   ` Lukasz Luba
2022-02-17 11:28                     ` Daniel Lezcano
2022-02-17 12:11                       ` Lukasz Luba
2022-02-17 12:33                         ` Daniel Lezcano
2022-02-17 12:37                           ` Lukasz Luba
2022-02-17 16:46                         ` Matthias Kaehlcke
2022-02-17 16:37                     ` Doug Anderson
2022-02-17 17:14                       ` Matthias Kaehlcke
2022-02-17 18:05                         ` Lukasz Luba
2022-02-17 18:27                       ` Daniel Lezcano
2022-02-16 17:21       ` Doug Anderson
2022-02-16 23:28         ` Lukasz Luba
2022-02-17 16:50           ` Doug Anderson
2022-02-17 17:58             ` Lukasz Luba
2022-02-17 18:18   ` Lukasz Luba
2022-02-22 17:05     ` Lukasz Luba
2022-02-22 18:12       ` Daniel Lezcano
2022-02-22 18:31         ` Lukasz Luba
2022-02-22 22:10           ` Daniel Lezcano
2022-02-23  9:10             ` Lukasz Luba
2022-02-07  7:30 ` Lukasz Luba [this message]
2022-02-07 10:41 ` [PATCH 0/2] Ignore Energy Model with abstract scale in IPA and DTPM Daniel Lezcano
2022-02-07 11:44   ` Lukasz Luba
2022-02-08  7:39     ` Daniel Lezcano
2022-02-08  9:47       ` Lukasz Luba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220207073036.14901-3-lukasz.luba@arm.com \
    --to=lukasz.luba@arm.com \
    --cc=Pierre.Gondois@arm.com \
    --cc=amit.kachhap@gmail.com \
    --cc=amitk@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®