From: Colin Ian King <colin.i.king@gmail.com>
To: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH][next] intel_th: remove redundant early initialization of pointer hubdrv
Date: Mon, 7 Feb 2022 13:47:51 +0000 [thread overview]
Message-ID: <20220207134751.337775-1-colin.i.king@gmail.com> (raw)
Pointer hubdrv is being initialized with a value that is never read,
it is being re-assigned the same value later on closer to where it
is being first used. The initialization is redundant and can be
removed.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/hwtracing/intel_th/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwtracing/intel_th/core.c b/drivers/hwtracing/intel_th/core.c
index 7e753a75d23b..f8fa0bd414fb 100644
--- a/drivers/hwtracing/intel_th/core.c
+++ b/drivers/hwtracing/intel_th/core.c
@@ -1037,7 +1037,7 @@ int intel_th_set_output(struct intel_th_device *thdev,
unsigned int master)
{
struct intel_th_device *hub = to_intel_th_hub(thdev);
- struct intel_th_driver *hubdrv = to_intel_th_driver(hub->dev.driver);
+ struct intel_th_driver *hubdrv;
int ret;
/* In host mode, this is up to the external debugger, do nothing. */
--
2.34.1
reply other threads:[~2022-02-07 13:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220207134751.337775-1-colin.i.king@gmail.com \
--to=colin.i.king@gmail.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®