From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Huacai Chen <chenhuacai@kernel.org>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH v2 1/2] MIPS: Loongson64: Clean up use of cc-ifversion
Date: Mon, 7 Feb 2022 18:35:50 +0100 [thread overview]
Message-ID: <20220207173550.GB16822@alpha.franken.de> (raw)
In-Reply-To: <20220125221925.3547683-1-nathan@kernel.org>
On Tue, Jan 25, 2022 at 03:19:24PM -0700, Nathan Chancellor wrote:
> This Makefile checks that GCC is 4.9 or newer, which is redundant after
> commit 76ae847497bc ("Documentation: raise minimum supported version of
> GCC to 5.1"), so cc-option can be removed.
>
> Clang does not support -march=loongson3a so it needs to continue to use
> -march=mips64r2, which no longer needs cc-option because all supported
> clang versions recognize this flag.
>
> -march=loonson3a can be used unconditionally with GCC because the
> minimum supported GCC version has been bumped past 4.9.0, which won't
> have the bug mentioned in the comment. The _MIPS_ISA macro redefinition
> can be removed at the same time for the same reason.
>
> Suggested-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> Suggested-by: Nick Desaulniers <ndesaulniers@google.com>
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
>
> v1 -> v2: https://lore.kernel.org/r/20220120214001.1879469-1-nathan@kernel.org/
>
> * Eliminate ld-option call (Jiaxun).
> * Eliminate _MIPS_ISA macro redefinitions (Nick).
>
> arch/mips/loongson64/Platform | 21 +++------------------
> 1 file changed, 3 insertions(+), 18 deletions(-)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2022-02-07 17:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 22:19 Nathan Chancellor
2022-01-25 22:19 ` [PATCH v2 2/2] MIPS: Loongson{2ef,64}: Wrap -mno-branch-likely with cc-option Nathan Chancellor
2022-02-07 17:36 ` Thomas Bogendoerfer
2022-02-07 17:35 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220207173550.GB16822@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=chenhuacai@kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®