From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C101C433EF for ; Mon, 7 Feb 2022 17:49:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353805AbiBGRqo (ORCPT ); Mon, 7 Feb 2022 12:46:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243283AbiBGRjb (ORCPT ); Mon, 7 Feb 2022 12:39:31 -0500 Received: from server.lespinasse.org (server.lespinasse.org [IPv6:2001:470:82ab::100:0]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C0D2C0401DA for ; Mon, 7 Feb 2022 09:39:31 -0800 (PST) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=lespinasse.org; i=@lespinasse.org; q=dns/txt; s=srv-54-ed; t=1644255571; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to : from; bh=uMxP1uR1GMWjz5rQCuyF02GDhukH9s01AnuJsjrwSno=; b=YlBq92pzvV6ya+NxhmqpzQOrb15Dwe/fCJvDg1qVIuo/P+nsf2ovRUDnQLI1I/Rey+1lg kvVPsbEDOvV8ypFAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lespinasse.org; i=@lespinasse.org; q=dns/txt; s=srv-54-rsa; t=1644255571; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to : from; bh=uMxP1uR1GMWjz5rQCuyF02GDhukH9s01AnuJsjrwSno=; b=dxYnoH/bYBJyklvC9tRz+aeodgNpOM0VcG+peohHQaS5dJtQCyBQpOAbQZZXjSC5on2YN A+i+MqkpSvABdWH2JY8xGcGLEOOVTcTkYdww8IYIrPvmTAHxH3j5nZDLOsiSdu2NdW0kHxp 1EzEDHfmW1GnML4Q6VwZKEAALEdRifabCWm14KLcDyigEbD9RpHWscW7vNmnkE+yOlTj59a qzULzgraGjWEd/qIr089ANyTZkdCzhxVzR/eKUXDRLMxrq55/TCDHzZFfBwg0ZPd6l2BIEq VOgGdoa6W+uPcGFd1b56YE9tCCZpiUQ7qJiL910tQNX+bwumvprkT0Hzsj4w== Received: by server.lespinasse.org (Postfix, from userid 1000) id 4C0E5160B2E; Mon, 7 Feb 2022 09:39:31 -0800 (PST) Date: Mon, 7 Feb 2022 09:39:31 -0800 From: Michel Lespinasse To: Liam Howlett Cc: Michel Lespinasse , Linux-MM , "linux-kernel@vger.kernel.org" , Andrew Morton , "kernel-team@fb.com" , Laurent Dufour , Jerome Glisse , Peter Zijlstra , Michal Hocko , Vlastimil Babka , Davidlohr Bueso , Matthew Wilcox , Rik van Riel , Paul McKenney , Song Liu , Suren Baghdasaryan , Minchan Kim , Joel Fernandes , David Rientjes , Axel Rasmussen , Andy Lutomirski Subject: Re: [PATCH v2 13/35] x86/mm: attempt speculative mm faults first Message-ID: <20220207173931.GC12302@lespinasse.org> References: <20220128131006.67712-1-michel@lespinasse.org> <20220128131006.67712-14-michel@lespinasse.org> <20220201171617.z5zgafitgolyv5np@revolver> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220201171617.z5zgafitgolyv5np@revolver> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 01, 2022 at 05:16:43PM +0000, Liam Howlett wrote: > > + vma = __find_vma(mm, address); > > + if (!vma || vma->vm_start > address) { > > This fits the vma_lookup() pattern - although you will have to work > around the locking issue still. This is the same for the other > platforms too; they fit the pattern also. In this case, I think it's just as well to follow the lines of the non-speculative path, which itself can't use vma_lookup() because it needs to handle the stack expansion case... -- Michel "walken" Lespinasse