From: Potin Lai <potin.lai@quantatw.com>
To: Guenter Roeck <linux@roeck-us.net>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Patrick Williams <patrick@stwcx.xyz>,
Potin Lai <potin.lai@quantatw.com>
Subject: [PATCH 1/2] usb: typec: tcpm: add interface for passing supported_pd_rev from tcpc_dev
Date: Tue, 8 Feb 2022 16:20:25 +0800 [thread overview]
Message-ID: <20220208082026.4855-2-potin.lai@quantatw.com> (raw)
In-Reply-To: <20220208082026.4855-1-potin.lai@quantatw.com>
Current TCPM allways assume using PD_MAX_REV for negotiation,
but for some USB controller only support PD 2.0, adding an interface
for passing supported_pd_rev from tcpc_dev.
Signed-off-by: Potin Lai <potin.lai@quantatw.com>
---
drivers/usb/typec/tcpm/tcpm.c | 14 ++++++++++++--
include/linux/usb/tcpm.h | 4 ++++
2 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
index 59d4fa2443f2..31770fa8643d 100644
--- a/drivers/usb/typec/tcpm/tcpm.c
+++ b/drivers/usb/typec/tcpm/tcpm.c
@@ -571,6 +571,16 @@ static bool tcpm_port_is_disconnected(struct tcpm_port *port)
port->cc2 == TYPEC_CC_OPEN)));
}
+static u32 tcpm_pd_supported_rev(struct tcpm_port *port)
+{
+ u32 rev = PD_MAX_REV;
+
+ if (port->tcpc->supported_pd_rev)
+ rev = port->tcpc->supported_pd_rev(port->tcpc);
+
+ return (rev > PD_MAX_REV) ? PD_MAX_REV : rev;
+}
+
/*
* Logging
*/
@@ -3932,7 +3942,7 @@ static void run_state_machine(struct tcpm_port *port)
typec_set_pwr_opmode(port->typec_port, opmode);
port->pwr_opmode = TYPEC_PWR_MODE_USB;
port->caps_count = 0;
- port->negotiated_rev = PD_MAX_REV;
+ port->negotiated_rev = tcpm_pd_supported_rev(port);
port->message_id = 0;
port->rx_msgid = -1;
port->explicit_contract = false;
@@ -4167,7 +4177,7 @@ static void run_state_machine(struct tcpm_port *port)
port->cc2 : port->cc1);
typec_set_pwr_opmode(port->typec_port, opmode);
port->pwr_opmode = TYPEC_PWR_MODE_USB;
- port->negotiated_rev = PD_MAX_REV;
+ port->negotiated_rev = tcpm_pd_supported_rev(port);
port->message_id = 0;
port->rx_msgid = -1;
port->explicit_contract = false;
diff --git a/include/linux/usb/tcpm.h b/include/linux/usb/tcpm.h
index bffc8d3e14ad..36282b2a9d9c 100644
--- a/include/linux/usb/tcpm.h
+++ b/include/linux/usb/tcpm.h
@@ -114,6 +114,9 @@ enum tcpm_transmit_type {
* Optional; The USB Communications Capable bit indicates if port
* partner is capable of communication over the USB data lines
* (e.g. D+/- or SS Tx/Rx). Called to notify the status of the bit.
+ * @supported_pd_rev:
+ * Optional; TCPM call this function to get supported PD revesion
+ * from lower level driver.
*/
struct tcpc_dev {
struct fwnode_handle *fwnode;
@@ -148,6 +151,7 @@ struct tcpc_dev {
bool pps_active, u32 requested_vbus_voltage);
bool (*is_vbus_vsafe0v)(struct tcpc_dev *dev);
void (*set_partner_usb_comm_capable)(struct tcpc_dev *dev, bool enable);
+ u32 (*supported_pd_rev)(struct tcpc_dev *dev);
};
struct tcpm_port;
--
2.17.1
next prev parent reply other threads:[~2022-02-08 8:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 8:20 [PATCH 0/2] Add a interface for passing supported PD rev from TCPC Potin Lai
2022-02-08 8:20 ` Potin Lai [this message]
2022-02-08 8:41 ` [PATCH 1/2] usb: typec: tcpm: add interface for passing supported_pd_rev from tcpc_dev Greg Kroah-Hartman
2022-02-08 8:20 ` [PATCH 2/2] usb: typec: fusb302: add support of supported_pd_rev Potin Lai
2022-02-08 11:22 ` [PATCH v2 0/2] Add a interface for passing supported PD rev from TCPC Potin Lai
2022-02-08 11:22 ` [PATCH v2 1/2] usb: typec: tcpm: add interface for passing supported_pd_rev from tcpc_dev Potin Lai
2022-02-08 15:25 ` Guenter Roeck
2022-02-08 16:41 ` kernel test robot
2022-02-09 6:53 ` kernel test robot
2022-02-08 11:22 ` [PATCH v2 2/2] usb: typec: fusb302: add support of supported_pd_rev Potin Lai
2022-02-08 15:22 ` Guenter Roeck
2022-02-09 3:34 ` Potin Lai
2022-02-09 17:50 ` Guenter Roeck
2022-02-11 8:35 ` Potin Lai (賴柏廷)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220208082026.4855-2-potin.lai@quantatw.com \
--to=potin.lai@quantatw.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=patrick@stwcx.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®