From: Xin Ji <xji@analogixsemi.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
bliang@analogixsemi.com, qwen@analogixsemi.com,
jli@analogixsemi.com, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v4 2/2] usb: typec: anx7411: Add Analogix PD ANX7411 support
Date: Tue, 8 Feb 2022 17:10:28 +0800 [thread overview]
Message-ID: <20220208091028.GA3679538@anxtwsw-Precision-3640-Tower> (raw)
In-Reply-To: <YgIuUIQ8EJqzNw6s@kroah.com>
On Tue, Feb 08, 2022 at 09:48:16AM +0100, Greg Kroah-Hartman wrote:
> On Tue, Feb 08, 2022 at 04:42:39PM +0800, Xin Ji wrote:
> > +#define DEBUG
>
> Please no. Rely on dynamic debugging options, not hard-coded ones like
> this.
>
> Please remove this.
Hi Greg k-h, thanks for your comment, I'll remove it in the next version.
Thanks,
Xin
>
> thanks,
>
> greg k-h
prev parent reply other threads:[~2022-02-08 9:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 8:42 [PATCH v4 1/2] dt-bindings: usb: Add analogix anx7411 PD binding Xin Ji
2022-02-08 8:42 ` [PATCH v4 2/2] usb: typec: anx7411: Add Analogix PD ANX7411 support Xin Ji
2022-02-08 8:48 ` Greg Kroah-Hartman
2022-02-08 9:10 ` Xin Ji [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220208091028.GA3679538@anxtwsw-Precision-3640-Tower \
--to=xji@analogixsemi.com \
--cc=bliang@analogixsemi.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jli@analogixsemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=qwen@analogixsemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®