From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 845CBC433F5 for ; Thu, 10 Feb 2022 17:45:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245299AbiBJRpN (ORCPT ); Thu, 10 Feb 2022 12:45:13 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:50562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245283AbiBJRpL (ORCPT ); Thu, 10 Feb 2022 12:45:11 -0500 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0A05F6F for ; Thu, 10 Feb 2022 09:45:12 -0800 (PST) Received: by mail-pl1-x62f.google.com with SMTP id j4so2450316plj.8 for ; Thu, 10 Feb 2022 09:45:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ygetL9EZuCFQPoKNeMK6/nbOJG24PUgQLTvCwbueOl0=; b=UjcPVqfYZN4M92rji0NMceX4ufLa9PXsp9CTK0g2BQ4YjM6OSLBcEej9kHKWNVlhpY vOOR18aiYY7qiBmAp4oe7dMQ20XSTrCKYsk6hgz7BoVfkCoSV+ceHTFBmkg6HmnedLbL YZ9ZIj9X0xpUiA7iDrTOrY9VKOPCdyIeJl6wU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ygetL9EZuCFQPoKNeMK6/nbOJG24PUgQLTvCwbueOl0=; b=Ac31Zf1xcsJaGjAB3UM8Ru67cN/4bdagmbtXj8kBGnsBTSz5KKra8+MXnG+oWhpnNO me71dYtMDN5fhT8g3AsZ/aze9hGRUVeDj0U6QHAVzUHN5/k2yINTuyVT/uDa/TDDdnn4 bQuOVWAdlNELxBwHwoVBuNcr65a66p8gE5SWaZXIBHj2VxLg/QcRUzYVc9ApKYSkx4uU cK8t6PvT46dGnSYHl5W43SP+e3sgU/HhYAjoUXNbIJHhTaYIGzblSsB83in4MaZVHi7C GezhUoloZCBUXGLxF7vrUMZrgr4so9x/r787BmZjyYMzlR2cAk1F440BaYz/E5QFRinb ENYw== X-Gm-Message-State: AOAM533fFehECKLN4y92OC3tCUEcP8eaxcCFfnTfnKzinm1nIUNI9QqY k8dYlJYi+n11DVqK/5Tl9bRbCQ== X-Google-Smtp-Source: ABdhPJzyg+5zMDVS023vY42euVCMQaqOCR6JZEFLnxAkiaXx/BFi5MdU/ZKqJjSVTEaoFdoUFwNiFA== X-Received: by 2002:a17:903:240b:: with SMTP id e11mr8402425plo.117.1644515112371; Thu, 10 Feb 2022 09:45:12 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id e28sm17430897pgm.23.2022.02.10.09.45.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Feb 2022 09:45:12 -0800 (PST) Date: Thu, 10 Feb 2022 09:45:11 -0800 From: Kees Cook To: Muhammad Usama Anjum Cc: Eric Biederman , Shuah Khan , Andrew Morton , kernel@collabora.com, kernelci@groups.io, "kernelci.org bot" , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests/exec: Add non-regular to TEST_GEN_PROGS Message-ID: <202202100945.1A6C624A@keescook> References: <20220210171323.1304501-1-usama.anjum@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220210171323.1304501-1-usama.anjum@collabora.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 10, 2022 at 10:13:23PM +0500, Muhammad Usama Anjum wrote: > non-regular file needs to be compiled and then copied to the output > directory. Remove it from TEST_PROGS and add it to TEST_GEN_PROGS. This > removes error thrown by rsync when non-regular object isn't found: > > rsync: [sender] link_stat "/linux/tools/testing/selftests/exec/non-regular" failed: No such file or directory (2) > rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1333) [sender=3.2.3] > > Fixes: 0f71241a8e32 ("selftests/exec: add file type errno tests") > Reported-by: "kernelci.org bot" > Signed-off-by: Muhammad Usama Anjum Eek, thanks for fixing this! Reviewed-by: Kees Cook -- Kees Cook