mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vikash Chandola <vikash.chandola@linux.intel.com>
To: iwona.winiarska@intel.com, linux@roeck-us.net, jdelvare@suse.com,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Vikash Chandola <vikash.chandola@linux.intel.com>
Subject: [PATCH] hwmon: (pmbus) Clear pmbus fault/warning bits before read
Date: Thu, 10 Feb 2022 12:41:54 +0000	[thread overview]
Message-ID: <20220210124154.1304852-1-vikash.chandola@linux.intel.com> (raw)

pmbus fault and warning bits are not cleared by itself once fault/warning
condition is not valid anymore. As per pmbus datasheet faults must be
cleared by user.
Modify hwmon behavior to clear latched status bytes if any bit in status
register is high prior to returning fresh data to userspace. If
fault/warning conditions are still applicable fault/warning bits will be
set and we will get updated data in second read.

Hwmon behavior is changed here. Now sysfs reads will reflect latest
values from pmbus slave, not latched values.
In case a transient warning/fault has happened in the past, it will no
longer be reported to userspace.

Signed-off-by: Vikash Chandola <vikash.chandola@linux.intel.com>
---
 drivers/hwmon/pmbus/pmbus_core.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c
index 776ee2237be2..1cc82d644079 100644
--- a/drivers/hwmon/pmbus/pmbus_core.c
+++ b/drivers/hwmon/pmbus/pmbus_core.c
@@ -577,6 +577,15 @@ static int pmbus_get_status(struct i2c_client *client, int page, int reg)
 		break;
 	default:
 		status = _pmbus_read_byte_data(client, page, reg);
+		if (status > 0) {
+			/*
+			 * Status greater than 0 could mean that there was a fault/warning.
+			 * Clear faults and do a second read to make sure we are not getting
+			 * stale values.
+			 */
+			pmbus_clear_fault_page(client, page);
+			status = _pmbus_read_byte_data(client, page, reg);
+		}
 		break;
 	}
 	if (status < 0)
-- 
2.25.1


             reply	other threads:[~2022-02-10 12:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-10 12:41 Vikash Chandola [this message]
2022-02-10 14:44 ` Guenter Roeck
2022-02-10 15:57   ` Vikash Chandola
2022-02-10 17:25     ` Guenter Roeck
2022-02-10 18:29       ` Vikash Chandola
2022-02-10 19:55         ` Guenter Roeck
2022-02-10 19:57           ` Guenter Roeck
2022-02-22 13:20             ` Vikash Chandola

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220210124154.1304852-1-vikash.chandola@linux.intel.com \
    --to=vikash.chandola@linux.intel.com \
    --cc=iwona.winiarska@intel.com \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®