From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA929C433F5 for ; Sun, 13 Feb 2022 10:32:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235018AbiBMKc4 (ORCPT ); Sun, 13 Feb 2022 05:32:56 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:49096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234989AbiBMKcu (ORCPT ); Sun, 13 Feb 2022 05:32:50 -0500 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72E9A5D65D for ; Sun, 13 Feb 2022 02:32:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644748365; x=1676284365; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=D1nXc/OYBdwU8DCxOHETpIebh+IAAU7yGjIaz6z7AVs=; b=A9dS0rWIPk247ODga7GKGoZNgBJVRGw+1207xByIsMHRPuqo0tnYblHj F3cTb4JLSlUT9BeLUZIZ6k2oOYArR60hzoT8TOKC1vKhgWOMzsggXvVZO dTvdb54U0tLr780oNNq7G+9qNu7IehsIlg4xMxkXXGguvfsTzRD+0yHou e3LD0VkPaLvgeA7EXWe2MuqS8RU0pKV0y4WitlQSHhx6kv+8+43DOJIIm 67Of3daw21ZKiOIIwNyZghlRCdqAATcbV2RXSBUguoQET/982oYRSHSK1 5+i/B3UCWpBFofdxX+iqMgw+7pcuqfJV3DEhZyRfhjpOZkr7+UN97Zz1F Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10256"; a="247532546" X-IronPort-AV: E=Sophos;i="5.88,365,1635231600"; d="scan'208";a="247532546" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2022 02:32:45 -0800 X-IronPort-AV: E=Sophos;i="5.88,365,1635231600"; d="scan'208";a="527474346" Received: from sannilnx.jer.intel.com ([10.12.231.79]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2022 02:32:42 -0800 From: Alexander Usyskin To: Greg Kroah-Hartman , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter Cc: Tomas Winkler , Alexander Usyskin , Vitaly Lubart , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v7 3/5] mei: gsc: setup char driver alive in spite of firmware handshake failure Date: Sun, 13 Feb 2022 12:32:13 +0200 Message-Id: <20220213103215.2440248-4-alexander.usyskin@intel.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220213103215.2440248-1-alexander.usyskin@intel.com> References: <20220213103215.2440248-1-alexander.usyskin@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Setup char device in spite of firmware handshake failure. In order to provide host access to the firmware status registers and other information required for the manufacturing process. Reviewed-by: Greg Kroah-Hartman Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- V5: Rebase V6: Rebase V7: add Greg KH Reviewed-by --- drivers/misc/mei/gsc-me.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/misc/mei/gsc-me.c b/drivers/misc/mei/gsc-me.c index 0afae70e0609..cf427f6fdec9 100644 --- a/drivers/misc/mei/gsc-me.c +++ b/drivers/misc/mei/gsc-me.c @@ -79,11 +79,12 @@ static int mei_gsc_probe(struct auxiliary_device *aux_dev, pm_runtime_set_active(device); pm_runtime_enable(device); - if (mei_start(dev)) { - dev_err(device, "init hw failure.\n"); - ret = -ENODEV; - goto err; - } + /* Continue to char device setup in spite of firmware handshake failure. + * In order to provide access to the firmware status registers to the user + * space via sysfs. + */ + if (mei_start(dev)) + dev_warn(device, "init hw failure.\n"); pm_runtime_set_autosuspend_delay(device, MEI_GSC_RPM_TIMEOUT); pm_runtime_use_autosuspend(device); -- 2.32.0