From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF6A6C43217 for ; Tue, 15 Feb 2022 15:35:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240564AbiBOPff (ORCPT ); Tue, 15 Feb 2022 10:35:35 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:43804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240622AbiBOPep (ORCPT ); Tue, 15 Feb 2022 10:34:45 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7213AC084E; Tue, 15 Feb 2022 07:30:43 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 18F2EB81A9A; Tue, 15 Feb 2022 15:30:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8FF8C340F1; Tue, 15 Feb 2022 15:30:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644939041; bh=gabu0dPFIjPq8dl7f+M37wwIEpMdISwwmTxGID7I7xw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=D09rC0mdWSCd0uYiYwZ5F6sLYl8oZ3y5kgaia+K2vwPlmcZTrlMD/lDbDcjFKiQ+k g0bMi2OeawU2IP+65X62jWZKhX7syngYL+Ai6EpZ9kJvAHDfhW5daaG94ghTKNDhPH R+RW/jmhiFrPVf38oXnDIA56Oa/4ok2KJOzuHk8uPuljgcpjWSf1HeqODBGGI0NlBm EBK/KUR1j9BqxxNeA1nk1BbEH32io/4PokCMgyNVyPibbs20/s8b9VBTNALpt2EAFS gUupqSzsSW+WxLQzDUcMKgt9uV7d6Xctr7XAP2ObBIPVGZY9tYZODHoBqJIT2GDT3e l12mwxJRkUMew== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ye Guojin , Zeal Robot , Tony Lindgren , Sasha Levin , linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 02/17] ARM: OMAP2+: adjust the location of put_device() call in omapdss_init_of Date: Tue, 15 Feb 2022 10:30:22 -0500 Message-Id: <20220215153037.581579-2-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220215153037.581579-1-sashal@kernel.org> References: <20220215153037.581579-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ye Guojin [ Upstream commit 34596ba380b03d181e24efd50e2f21045bde3696 ] This was found by coccicheck: ./arch/arm/mach-omap2/display.c, 272, 1-7, ERROR missing put_device; call of_find_device_by_node on line 258, but without a corresponding object release within this function. Move the put_device() call before the if judgment. Reported-by: Zeal Robot Signed-off-by: Ye Guojin Signed-off-by: Tony Lindgren Signed-off-by: Sasha Levin --- arch/arm/mach-omap2/display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/display.c b/arch/arm/mach-omap2/display.c index 46012ca812f48..1bd64f6ba8cfe 100644 --- a/arch/arm/mach-omap2/display.c +++ b/arch/arm/mach-omap2/display.c @@ -263,9 +263,9 @@ static int __init omapdss_init_of(void) } r = of_platform_populate(node, NULL, NULL, &pdev->dev); + put_device(&pdev->dev); if (r) { pr_err("Unable to populate DSS submodule devices\n"); - put_device(&pdev->dev); return r; } -- 2.34.1