From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E100C433EF for ; Tue, 15 Feb 2022 16:32:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241583AbiBOQcU (ORCPT ); Tue, 15 Feb 2022 11:32:20 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:49214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241582AbiBOQcP (ORCPT ); Tue, 15 Feb 2022 11:32:15 -0500 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74DEF8A6C3 for ; Tue, 15 Feb 2022 08:32:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644942724; x=1676478724; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=kOl4ZoUw8hbyoH6yx63ZM9ci77NdjsTJQdRP7iPomh8=; b=DHB8eV1vQOXuSCSXIlRjrlOKfixacZt9KHcim9qigyQFxCVvoQdpPcHv HcUD8PF+wobnBfQe09uSDTHt/nvi41Rsp8j7+Q7ihhwNiIHM6rZ2dbISy ucmBbZiRkR72TYoynYPCXEU7j8h7hkApU1pjFRrt2qdaGEiiWwYdF6NuC ZqFourOdenRgwmYSg6KCYdK6weFlWXbn1SPeoECGTHvd8YQHwe821mAig OhU/Ru3Z3mRw+6UzXEQ2DBlR0dOvfchefGSrCBulWcqMvNKSkVza4yy9y wbo34Q6mSYqCbhTAGHl9VFAC6udh3Kv+W5JOAaNoe07XHyDtZNN4ovaEq w==; X-IronPort-AV: E=McAfee;i="6200,9189,10258"; a="231018135" X-IronPort-AV: E=Sophos;i="5.88,371,1635231600"; d="scan'208";a="231018135" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2022 08:32:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,371,1635231600"; d="scan'208";a="539411451" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga007.fm.intel.com with ESMTP; 15 Feb 2022 08:31:59 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 3DA3D107; Tue, 15 Feb 2022 18:32:14 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Thomas Zimmermann , Geert Uytterhoeven Subject: [PATCH v1 1/1] drm/i915/selftests: Replace too verbose for-loop with simpler while Date: Tue, 15 Feb 2022 18:32:13 +0200 Message-Id: <20220215163213.54917-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It's hard to parse for-loop which has some magic calculations inside. Much cleaner to use while-loop directly. Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/i915/selftests/i915_syncmap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/selftests/i915_syncmap.c b/drivers/gpu/drm/i915/selftests/i915_syncmap.c index 47f4ae18a1ef..26981d1c3025 100644 --- a/drivers/gpu/drm/i915/selftests/i915_syncmap.c +++ b/drivers/gpu/drm/i915/selftests/i915_syncmap.c @@ -36,10 +36,10 @@ __sync_print(struct i915_syncmap *p, unsigned int i, X; if (depth) { - unsigned int d; + unsigned int d = depth; - for (d = 0; d < depth - 1; d++) { - if (last & BIT(depth - d - 1)) + while (d--) { + if (last & BIT(d)) len = scnprintf(buf, *sz, "| "); else len = scnprintf(buf, *sz, " "); -- 2.34.1