From: Christoph Hellwig <hch@lst.de>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>, Christoph Hellwig <hch@lst.de>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
kernel test robot <lkp@intel.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sh: Convert nommu io{re,un}map() to static inline functions
Date: Tue, 15 Feb 2022 20:16:08 +0100 [thread overview]
Message-ID: <20220215191608.GA25076@lst.de> (raw)
In-Reply-To: <4ed0a7a0d3fa912a5b44c451884818f2c138ef42.1644914600.git.geert+renesas@glider.be>
On Tue, Feb 15, 2022 at 09:51:05AM +0100, Geert Uytterhoeven wrote:
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Fixes: 13f1fc870dd74713 ("sh: move the ioremap implementation out of line")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
> ---
> This is actually the third time this change was made, as Christoph
> converted iounmap() to a macro before in commit 98c90e5ea34e98bd ("sh:
> remove __iounmap"), reverting commit 733f0025f0fb43e3 ("sh: prevent
> warnings when using iounmap").
>
> Probably sh-nommu should include <asm-generic/io.h>, but that would
> require a lot more changes.
I don't think it would be all that bad. But between the breakage and
the fact that sh is almost unmaintained let's get the quick fix in if
we can..
prev parent reply other threads:[~2022-02-15 19:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 8:51 Geert Uytterhoeven
2022-02-15 12:03 ` Jonathan Cameron
2022-02-15 19:16 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220215191608.GA25076@lst.de \
--to=hch@lst.de \
--cc=Jonathan.Cameron@huawei.com \
--cc=arnd@arndb.de \
--cc=dalias@libc.org \
--cc=geert+renesas@glider.be \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=lkp@intel.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®