From: Guru Das Srinagesh <quic_gurus@quicinc.com>
To: Satya Priya <quic_c_skakit@quicinc.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Lee Jones <lee.jones@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Das Srinagesh <gurus@codeaurora.org>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <swboyd@chromium.org>,
<quic_collinsd@quicinc.com>, <quic_subbaram@quicinc.com>,
<quic_jprakash@quicinc.com>
Subject: Re: [PATCH V6 3/6] mfd: pm8008: Add mfd cell struct to register LDOs
Date: Tue, 15 Feb 2022 18:58:39 -0800 [thread overview]
Message-ID: <20220216025839.GA28938@hu-gurus-sd.qualcomm.com> (raw)
In-Reply-To: <1644915231-7308-4-git-send-email-quic_c_skakit@quicinc.com>
On Tue, Feb 15, 2022 at 02:23:48PM +0530, Satya Priya wrote:
> static const struct of_device_id pm8008_match[] = {
> - { .compatible = "qcom,pm8008", },
> - { },
> + { .compatible = "qcom,pm8008", .data = (void *)PM8008_INFRA},
> + { .compatible = "qcom,pm8008-regulators", .data = (void *)PM8008_REGULATORS},
Typo perhaps: Please set the last element of this array to the sentinel value NULL.
{},
> };
> +MODULE_DEVICE_TABLE(of, pm8008_match)
Missing a semicolon at the end.
>
> static struct i2c_driver pm8008_mfd_driver = {
> .driver = {
next prev parent reply other threads:[~2022-02-16 2:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 8:53 [PATCH V6 0/6] Add Qualcomm Technologies, Inc. PM8008 regulator driver Satya Priya
2022-02-15 8:53 ` [PATCH V6 1/6] dt-bindings: regulator: Add pm8008 regulator bindings Satya Priya
2022-02-15 8:53 ` [PATCH V6 2/6] dt-bindings: mfd: pm8008: Add regulators node Satya Priya
2022-02-16 2:04 ` Stephen Boyd
2022-02-16 9:49 ` Satya Priya Kakitapalli (Temp)
2022-02-16 4:31 ` Subbaraman Narayanamurthy
2022-02-16 9:50 ` Satya Priya Kakitapalli (Temp)
2022-02-15 8:53 ` [PATCH V6 3/6] mfd: pm8008: Add mfd cell struct to register LDOs Satya Priya
2022-02-15 13:46 ` kernel test robot
2022-02-15 14:18 ` kernel test robot
2022-02-16 2:58 ` Guru Das Srinagesh [this message]
2022-02-16 9:49 ` Satya Priya Kakitapalli (Temp)
2022-02-15 8:53 ` [PATCH V6 4/6] regulator: Add a regulator driver for the PM8008 PMIC Satya Priya
2022-02-15 8:53 ` [PATCH V6 5/6] arm64: dts: qcom: pm8008: Add base dts file Satya Priya
2022-02-15 8:53 ` [PATCH V6 6/6] arm64: dts: qcom: sc7280: Add pm8008 support for sc7280-idp Satya Priya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220216025839.GA28938@hu-gurus-sd.qualcomm.com \
--to=quic_gurus@quicinc.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gurus@codeaurora.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_c_skakit@quicinc.com \
--cc=quic_collinsd@quicinc.com \
--cc=quic_jprakash@quicinc.com \
--cc=quic_subbaram@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®