From: "Paul E. McKenney" <paulmck@kernel.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Rik van Riel <riel@surriel.com>,
linux-kernel@vger.kernel.org, kernel-team@fb.com,
Chris Mason <clm@fb.com>,
linux-fsdevel@vger.kernel.org,
Giuseppe Scrivano <gscrivan@redhat.com>
Subject: Re: [PATCH][RFC] ipc,fs: use rcu_work to free struct ipc_namespace
Date: Thu, 17 Feb 2022 21:31:20 -0800 [thread overview]
Message-ID: <20220218053120.GV4285@paulmck-ThinkPad-P17-Gen-1> (raw)
In-Reply-To: <Yg8StKzTWh+7FLuA@zeniv-ca.linux.org.uk>
On Fri, Feb 18, 2022 at 03:29:56AM +0000, Al Viro wrote:
> On Thu, Feb 17, 2022 at 03:36:20PM -0500, Rik van Riel wrote:
> > The patch works, but a cleanup question for Al Viro:
> >
> > How do we get rid of #include "../fs/mount.h" and the raw ->mnt_ns = NULL thing
> > in the cleanest way?
>
> Hell knows... mnt_make_shortterm(mnt) with big, fat warning along the lines of
> "YOU MUST HAVE AN RCU GRACE PERIOD BEFORE YOU DROP THAT REFERENCE!!!", perhaps?
Rik's patch uses queue_rcu_work(), which always uses a normal grace
period. Therefore, one way of checking that an RCU grace period has
elapsed is as follows:
Step 1: Get a snapshot of the normal grace-period state:
rcuseq = get_state_synchronize_rcu(); // In mainline
Step 2: Verify that a normal grace period has elapsed since step 1:
WARN_ON_ONCE(!poll_state_synchronize_rcu(rcuseq));
These functions are both in mainline.
And apologies for my answer on IRC being unhelpful. Here is hoping that
this is more to the point.
Thanx, Paul
------------------------------------------------------------------------
PS. Just in case it ever becomes relevant, if Rik's patch were instead
to use synchronize_rcu() or synchronize_rcu_expedited() to wait for
the grace period, it would be necessary to capture both the normal
and expedited grace-period state:
Step 1: Get a snapshot of both the normal and the expedited state:
rcuseq = get_state_synchronize_rcu();
rcuxseq = get_state_synchronize_rcu_expedited();
Step 2: Verify that either a normal or expedited grace period has
elapsed since step 1:
WARN_ON_ONCE(!poll_state_synchronize_rcu(rcuseq) &&
!poll_state_synchronize_rcu_expedited(rcuxseq));
The reason for doing both is that synchronize_rcu_expedited() and
synchronize_rcu() can both be switched between using normal and expedited
grace periods. Not just at boot time, but also at runtime. Fun.
The two expedited functions are in -rcu rather than mainline, so if
someone does ever need them, please let me know.
next prev parent reply other threads:[~2022-02-18 5:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 20:36 Rik van Riel
2022-02-17 21:55 ` Paul E. McKenney
2022-02-18 3:29 ` Al Viro
2022-02-18 5:31 ` Paul E. McKenney [this message]
2022-02-18 13:01 ` Christian Brauner
2022-02-18 16:08 ` Eric W. Biederman
2022-02-18 16:41 ` Paul E. McKenney
2022-02-18 16:54 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220218053120.GV4285@paulmck-ThinkPad-P17-Gen-1 \
--to=paulmck@kernel.org \
--cc=clm@fb.com \
--cc=gscrivan@redhat.com \
--cc=kernel-team@fb.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=riel@surriel.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®