From: David Vernet <void@manifault.com>
To: peterz@infradead.org, linux-kernel@vger.kernel.org
Cc: void@manifault.com, kernel-team@fb.com, mingo@redhat.com,
juri.lelli@redhat.com, vincent.guittot@linaro.org,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, bristot@redhat.com
Subject: [PATCH] sched: Fix stale try_invoke_on_locked_down_task comment
Date: Fri, 18 Feb 2022 07:23:29 -0800 [thread overview]
Message-ID: <20220218152328.883437-1-void@manifault.com> (raw)
In-Reply-To: <20211230193633.1295745-1-void@manifault.com>
In 9b3c4ab3045e, try_invoke_on_locked_down_task() was renamed to
task_call_func(), and several callers, comments, etc were updated to use
the new name and signature. There was one comment in try_to_wake_up() that
was missed, and still refers to the old name. This diff corrects that
comment to refer to the new name.
Fixes: 9b3c4ab3045e ("sched,rcu: Rework try_invoke_on_locked_down_task()")
Signed-off-by: David Vernet <void@manifault.com>
---
kernel/sched/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 1e08b02e0cd5..d76e3da0d7d6 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -4042,7 +4042,7 @@ try_to_wake_up(struct task_struct *p, unsigned int state, int wake_flags)
* Pairs with the LOCK+smp_mb__after_spinlock() on rq->lock in
* __schedule(). See the comment for smp_mb__after_spinlock().
*
- * A similar smb_rmb() lives in try_invoke_on_locked_down_task().
+ * A similar smb_rmb() lives in task_call_func().
*/
smp_rmb();
if (READ_ONCE(p->on_rq) && ttwu_runnable(p, wake_flags))
--
2.30.2
prev parent reply other threads:[~2022-02-18 15:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-30 19:36 David Vernet
2022-02-18 15:23 ` David Vernet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220218152328.883437-1-void@manifault.com \
--to=void@manifault.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®