mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Desmond Yan <desmond.yan@broadcom.com>
To: Scott Branden <scott.branden@broadcom.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: bcm-kernel-feedback-list@broadcom.com,
	linux-kernel@vger.kernel.org,
	Desmond Yan <desmond.yan@broadcom.com>
Subject: [PATCH v1 1/1] misc: bcm-vk: add kconfig for supporting viper chip
Date: Fri, 18 Feb 2022 12:08:11 -0800	[thread overview]
Message-ID: <20220218200811.17136-1-desmond.yan@broadcom.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1619 bytes --]

Add kconfig for enabling bcm-vk driver to support the viper chip.
Default is off and only explicitly configured that the viper chip
would be discovered by the driver and loaded for usage.

Tested-by: Desmond Yan <desmond.yan@broadcom.com>
Signed-off-by: Desmond Yan <desmond.yan@broadcom.com>
---
 drivers/misc/bcm-vk/Kconfig      | 10 ++++++++++
 drivers/misc/bcm-vk/bcm_vk_dev.c |  2 ++
 2 files changed, 12 insertions(+)

diff --git a/drivers/misc/bcm-vk/Kconfig b/drivers/misc/bcm-vk/Kconfig
index 68a972772b99..43910a378163 100644
--- a/drivers/misc/bcm-vk/Kconfig
+++ b/drivers/misc/bcm-vk/Kconfig
@@ -16,6 +16,16 @@ config BCM_VK
 
 	  If unsure, say N.
 
+config BCM_VK_VIPER
+	bool "VK driver for VIPER"
+	depends on BCM_VK
+	help
+	  Turn on to enable using the vk driver for the viper variant.
+	  Used for development environments where viper uses VK driver
+	  and VK firmware rather than an alternate firmware and driver.
+
+	  If unsure, say N.
+
 config BCM_VK_TTY
 	bool "Enable tty ports on a Broadcom VK Accelerator device"
 	depends on TTY
diff --git a/drivers/misc/bcm-vk/bcm_vk_dev.c b/drivers/misc/bcm-vk/bcm_vk_dev.c
index ad639ee85b2a..41dbfa4fa4a5 100644
--- a/drivers/misc/bcm-vk/bcm_vk_dev.c
+++ b/drivers/misc/bcm-vk/bcm_vk_dev.c
@@ -1633,7 +1633,9 @@ static void bcm_vk_shutdown(struct pci_dev *pdev)
 
 static const struct pci_device_id bcm_vk_ids[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_VALKYRIE), },
+#if defined(CONFIG_BCM_VK_VIPER)
 	{ PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_VIPER), },
+#endif
 	{ }
 };
 MODULE_DEVICE_TABLE(pci, bcm_vk_ids);
-- 
2.17.1


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4206 bytes --]

             reply	other threads:[~2022-02-18 20:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-18 20:08 Desmond Yan [this message]
2022-02-19  7:33 ` Greg Kroah-Hartman
2022-02-22 15:41   ` Desmond Yan (APD)
2022-02-22 17:13     ` Greg Kroah-Hartman
2022-02-23  5:14       ` Desmond yan
2022-02-23  7:26         ` Greg Kroah-Hartman
2022-02-23 17:59           ` Scott Branden
2022-02-23 18:27             ` Greg Kroah-Hartman
2022-02-23 18:29               ` Scott Branden

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220218200811.17136-1-desmond.yan@broadcom.com \
    --to=desmond.yan@broadcom.com \
    --cc=arnd@arndb.de \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=scott.branden@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®