mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Yifan Zhang <yifan1.zhang@amd.com>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	Alex Deucher <alexander.deucher@amd.com>,
	Huang Rui <ray.huang@amd.com>
Subject: [PATCH] drm/amd/pm: fix returnvar.cocci warnings
Date: Sun, 20 Feb 2022 23:50:19 +0800	[thread overview]
Message-ID: <20220220155019.GA5906@a7651148d694> (raw)
In-Reply-To: <202202202323.i1r9Jm11-lkp@intel.com>

From: kernel test robot <lkp@intel.com>

drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c:235:5-8: Unneeded variable: "ret". Return "0" on line 243


 Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

Fixes: 068ea8bdc0aa ("drm/amd/pm: add smu_v13_0_5_ppt implementation")
CC: Yifan Zhang <yifan1.zhang@amd.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://gitlab.freedesktop.org/agd5f/linux.git drm-next
head:   ad72a74cfe7edab15aef40519727a388285e7510
commit: 068ea8bdc0aacb3bba3d1392ed41cc1116a671b8 [96/114] drm/amd/pm: add smu_v13_0_5_ppt implementation
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago

 drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c |    7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c
@@ -229,18 +229,13 @@ static bool smu_v13_0_5_is_dpm_running(s
 
 static int smu_v13_0_5_post_smu_init(struct smu_context *smu)
 {
-	/*
-	struct amdgpu_device *adev = smu->adev;
-	*/
-	int ret = 0;
-
 	/* allow message will be sent after enable gfxoff on smu 13.0.5 */
 	/*
 	ret = smu_cmn_send_smc_msg(smu, SMU_MSG_EnableGfxOff, NULL);
 	if (ret)
 		dev_err(adev->dev, "Failed to Enable GfxOff!\n");
 	*/
-	return ret;
+	return 0;
 }
 
 static int smu_v13_0_5_mode_reset(struct smu_context *smu, int type)

      reply	other threads:[~2022-02-20 15:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-20 15:52 [agd5f:drm-next 96/114] drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c:235:5-8: Unneeded variable: "ret". Return "0" on line 243 kernel test robot
2022-02-20 15:50 ` kernel test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220220155019.GA5906@a7651148d694 \
    --to=lkp@intel.com \
    --cc=alexander.deucher@amd.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ray.huang@amd.com \
    --cc=yifan1.zhang@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®