Re: [PATCH v6 09/13] module: Move kallsyms support into a separate file

[Aaron Tomlin <atomlin@atomlin.com>]

On Mon 2022-02-21 10:49 +0000, Christophe Leroy wrote:
> Le 18/02/2022 à 22:25, Aaron Tomlin a écrit :
> > No functional change.
> > 
> > This patch migrates kallsyms code out of core module
> > code kernel/module/kallsyms.c
> > 
> > Signed-off-by: Aaron Tomlin <atomlin@redhat.com>
> > ---
> >   kernel/module/Makefile   |   1 +
> >   kernel/module/internal.h |  32 +++
> >   kernel/module/kallsyms.c | 502 ++++++++++++++++++++++++++++++++++++
> >   kernel/module/main.c     | 531 +--------------------------------------
> >   4 files changed, 541 insertions(+), 525 deletions(-)
> >   create mode 100644 kernel/module/kallsyms.c
> > 
> 
>    CC      kernel/module/main.o
> kernel/module/main.c: In function 'load_module':
> kernel/module/main.c:3379:9: error: implicit declaration of function 
> 'init_build_id' [-Werror=implicit-function-declaration]
>   3379 |         init_build_id(mod, info);
>        |         ^~~~~~~~~~~~~
> cc1: some warnings being treated as errors
> make[2]: *** [scripts/Makefile.build:288 : kernel/module/main.o] Erreur 1

Christophe,

I assume both Kconfig option CONFIG_KALLSYMS and CONFIG_STACKTRACE_BUILD_ID
was not enabled. I'll address this.

Thanks,

-- 
Aaron Tomlin