From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
Kai-Heng Feng <kai.heng.feng@canonical.com>
Subject: [PATCH v2 2/8] iio: accel: adxl345: Set driver_data for OF enumeration
Date: Tue, 22 Feb 2022 11:00:03 +0200 [thread overview]
Message-ID: <20220222090009.2060-2-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20220222090009.2060-1-andriy.shevchenko@linux.intel.com>
In order to enable this driver on mode platforms, assign driver_data
field in the OF device ID table.
While at it, make sure that device type is not 0 which may be wrongly
interpreted by device property APIs in the future.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v2: used proper casting for the supplied data (LKP)
drivers/iio/accel/adxl345.h | 4 ++--
drivers/iio/accel/adxl345_i2c.c | 4 ++--
drivers/iio/accel/adxl345_spi.c | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/iio/accel/adxl345.h b/drivers/iio/accel/adxl345.h
index af0fdd02c4f2..5a68d4dac717 100644
--- a/drivers/iio/accel/adxl345.h
+++ b/drivers/iio/accel/adxl345.h
@@ -9,8 +9,8 @@
#define _ADXL345_H_
enum adxl345_device_type {
- ADXL345,
- ADXL375,
+ ADXL345 = 1,
+ ADXL375 = 2,
};
int adxl345_core_probe(struct device *dev, struct regmap *regmap,
diff --git a/drivers/iio/accel/adxl345_i2c.c b/drivers/iio/accel/adxl345_i2c.c
index e3205dce91b8..4c6efe2eefc1 100644
--- a/drivers/iio/accel/adxl345_i2c.c
+++ b/drivers/iio/accel/adxl345_i2c.c
@@ -44,8 +44,8 @@ static const struct i2c_device_id adxl345_i2c_id[] = {
MODULE_DEVICE_TABLE(i2c, adxl345_i2c_id);
static const struct of_device_id adxl345_of_match[] = {
- { .compatible = "adi,adxl345" },
- { .compatible = "adi,adxl375" },
+ { .compatible = "adi,adxl345", .data = (const void *)ADXL345 },
+ { .compatible = "adi,adxl375", .data = (const void *)ADXL375 },
{ },
};
diff --git a/drivers/iio/accel/adxl345_spi.c b/drivers/iio/accel/adxl345_spi.c
index 9223302fdd46..72550132b1bb 100644
--- a/drivers/iio/accel/adxl345_spi.c
+++ b/drivers/iio/accel/adxl345_spi.c
@@ -46,8 +46,8 @@ static const struct spi_device_id adxl345_spi_id[] = {
MODULE_DEVICE_TABLE(spi, adxl345_spi_id);
static const struct of_device_id adxl345_of_match[] = {
- { .compatible = "adi,adxl345" },
- { .compatible = "adi,adxl375" },
+ { .compatible = "adi,adxl345", .data = (const void *)ADXL345 },
+ { .compatible = "adi,adxl375", .data = (const void *)ADXL375 },
{ },
};
--
2.34.1
next prev parent reply other threads:[~2022-02-22 9:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 9:00 [PATCH v2 1/8] iio: accel: adxl345: Convert to use dev_err_probe() Andy Shevchenko
2022-02-22 9:00 ` Andy Shevchenko [this message]
2022-02-22 9:00 ` [PATCH v2 3/8] iio: accel: adxl345: Get rid of name parameter in adxl345_core_probe() Andy Shevchenko
2022-02-26 18:54 ` Jonathan Cameron
2022-02-22 9:00 ` [PATCH v2 4/8] iio: accel: adxl345: Make use of device properties Andy Shevchenko
2022-02-26 19:05 ` Jonathan Cameron
2022-02-27 11:22 ` Jonathan Cameron
2022-02-22 9:00 ` [PATCH v2 5/8] iio: accel: adxl345: Add ACPI HID table Andy Shevchenko
2022-02-22 9:00 ` [PATCH v2 6/8] iio: accel: adxl345: Extract adxl345_powerup() helper Andy Shevchenko
2022-02-22 9:00 ` [PATCH v2 7/8] iio: accel: adxl345: Drop comma in terminator entries Andy Shevchenko
2022-02-22 9:00 ` [PATCH v2 8/8] iio: accel: adxl345: Remove unneeded blank lines Andy Shevchenko
2022-02-23 3:10 ` [PATCH v2 1/8] iio: accel: adxl345: Convert to use dev_err_probe() Kai-Heng Feng
2022-02-26 19:12 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220222090009.2060-2-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=jic23@kernel.org \
--cc=kai.heng.feng@canonical.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®