From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DBEFC433F5 for ; Tue, 22 Feb 2022 21:27:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235511AbiBVV2G (ORCPT ); Tue, 22 Feb 2022 16:28:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235832AbiBVV1l (ORCPT ); Tue, 22 Feb 2022 16:27:41 -0500 Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 519208E196 for ; Tue, 22 Feb 2022 13:27:11 -0800 (PST) Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 21MLQgJt094027; Tue, 22 Feb 2022 15:26:42 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1645565202; bh=4IgUtNPOVL10Vp/1imi/uYZI63freW9H4+vX2DPlXSY=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=LAiCT48cWfLm7s/Qi781s8RcKxLPuwos03bIGtQxAOiGatxkEHNkQX9tlLsVaLlA/ +gMHbBht/OQ26yNsOaS3bNUeKIhwKyvFWQNTKLjT3EO8okdbAqUrLiDGa0NBFFfy77 t4uiayVOEan2qDs1T2LWQHz9oP/9jPlcoq9qXJnQ= Received: from DFLE105.ent.ti.com (dfle105.ent.ti.com [10.64.6.26]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 21MLQgUv093354 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 22 Feb 2022 15:26:42 -0600 Received: from DFLE115.ent.ti.com (10.64.6.36) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Tue, 22 Feb 2022 15:26:42 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Tue, 22 Feb 2022 15:26:42 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 21MLQgU8074960; Tue, 22 Feb 2022 15:26:42 -0600 Date: Tue, 22 Feb 2022 15:26:42 -0600 From: Nishanth Menon To: Bjorn Andersson CC: Rahul T R , , , , , , , , , , , , , Subject: Re: [PATCH] arm64: defconfig: Enable configs for DisplayPort on J721e Message-ID: <20220222212642.vwtw7xiz7cck63ea@zombie> References: <20220222180703.30401-1-r-ravikumar@ti.com> <20220222193930.sbc5xlsofhg3amgk@overrun> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12:40-20220222, Bjorn Andersson wrote: > On Tue 22 Feb 11:39 PST 2022, Nishanth Menon wrote: > > > On 23:37-20220222, Rahul T R wrote: > > > Enable DRM and PHY configs required for supporting > > > DisplayPort on J721e > > > > > > Signed-off-by: Rahul T R > > > --- > > > arch/arm64/configs/defconfig | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > > > index 9f23d7ec1232..b0cb894a392e 100644 > > > --- a/arch/arm64/configs/defconfig > > > +++ b/arch/arm64/configs/defconfig > > > @@ -702,6 +702,9 @@ CONFIG_DRM_EXYNOS_DSI=y > > > CONFIG_DRM_EXYNOS_HDMI=y > > > CONFIG_DRM_EXYNOS_MIC=y > > > CONFIG_DRM_ROCKCHIP=m > > > +CONFIG_DRM_TIDSS=m > > > +CONFIG_DRM_DISPLAY_CONNECTOR=m > > > +CONFIG_DRM_CDNS_MHDP8546=m > > > > Please use savedefconfig to place the changes in the correct location > > > > Just to clarify the request, use "make savedefconfig" to generate a > defconfig, then based on that put _only_ the relevant changes in the > commit. Yup, thanks for clarifying. > > > Also indicate changes if any in vmlinux in commit message. > > > > Nishanth, what are you asking for here? Just a mentioning if this has > any impact to vmlinux (or is isolated to the modules selected), or are > you asking for anything specific? In this case, just ensure to state that vmlinux size has'nt changed, in case where we see a =y, we should indicate via ./scripts/bloat-o-meter change that is introduced and if yes, we should explain why this is fundamental to system boot. Why is this necessary? This is to prevent product specific configurations (such as early display banner, chime etc) from creeping and increasing vmlinux size which has an impact for all ARM SoCs. [...] -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D