From: Kate Hsuan <hpa@redhat.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>,
Bingbu Cao <bingbu.cao@intel.com>,
Tianshu Qiu <tian.shu.qiu@intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, hdegoede@redhat.com,
Kate Hsuan <hpa@redhat.com>
Subject: [PATCH 1/1] staging: media: ipu3: Fix AF x_start position when rightmost stripe is used
Date: Wed, 23 Feb 2022 17:06:48 +0800 [thread overview]
Message-ID: <20220223090648.41989-2-hpa@redhat.com> (raw)
In-Reply-To: <20220223090648.41989-1-hpa@redhat.com>
For the AF configuration, if the rightmost stripe is used, the AF scene
will be at the incorrect location of the sensor.
The AF coordinate may be set to the right part of the sensor. This
configuration would lead to x_start being greater than the
down_scaled_stripes offset and the leftmost stripe would be disabled
and only the rightmost stripe is used to control the AF coordinate. If
the x_start doesn't perform any adjustments, the AF coordinate will be
at the wrong place of the sensor since down_scaled_stripes offset
would be the new zero of the coordinate system.
In this patch, if only the rightmost stripe is used, x_start should
minus down_scaled_stripes offset to maintain its correctness of AF
scene coordinate.
Signed-off-by: Kate Hsuan <hpa@redhat.com>
---
drivers/staging/media/ipu3/ipu3-css-params.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/media/ipu3/ipu3-css-params.c b/drivers/staging/media/ipu3/ipu3-css-params.c
index d9e3c3785075..efe4de8ef205 100644
--- a/drivers/staging/media/ipu3/ipu3-css-params.c
+++ b/drivers/staging/media/ipu3/ipu3-css-params.c
@@ -2556,6 +2556,14 @@ int imgu_css_cfg_acc(struct imgu_css *css, unsigned int pipe,
/* Enable only for rightmost stripe, disable left */
acc->af.stripes[0].grid_cfg.y_start &=
~IPU3_UAPI_GRID_Y_START_EN;
+ acc->af.stripes[0].grid_cfg.x_start -=
+ acc->stripe.down_scaled_stripes[1].offset;
+ acc->af.stripes[0].grid_cfg.x_end -=
+ acc->stripe.down_scaled_stripes[1].offset;
+ acc->af.stripes[1].grid_cfg.x_start -=
+ acc->stripe.down_scaled_stripes[1].offset;
+ acc->af.stripes[1].grid_cfg.x_end -=
+ acc->stripe.down_scaled_stripes[1].offset;
} else if (acc->af.config.grid_cfg.x_end <=
acc->stripe.bds_out_stripes[0].width - min_overlap) {
/* Enable only for leftmost stripe, disable right */
@@ -2563,7 +2571,6 @@ int imgu_css_cfg_acc(struct imgu_css *css, unsigned int pipe,
~IPU3_UAPI_GRID_Y_START_EN;
} else {
/* Enable for both stripes */
-
acc->af.stripes[0].grid_cfg.width =
(acc->stripe.bds_out_stripes[0].width - min_overlap -
acc->af.config.grid_cfg.x_start + 1) >>
--
2.35.1
next prev parent reply other threads:[~2022-02-23 9:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 9:06 [PATCH 0/1] " Kate Hsuan
2022-02-23 9:06 ` Kate Hsuan [this message]
2022-02-23 11:15 ` [PATCH 1/1] " Kate Hsuan
2022-03-03 9:09 ` Sakari Ailus
2022-03-09 5:31 ` Kate Hsuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220223090648.41989-2-hpa@redhat.com \
--to=hpa@redhat.com \
--cc=bingbu.cao@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tian.shu.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®