From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37B00C433FE for ; Wed, 23 Feb 2022 23:37:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244851AbiBWXhj (ORCPT ); Wed, 23 Feb 2022 18:37:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244412AbiBWXhh (ORCPT ); Wed, 23 Feb 2022 18:37:37 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9BBBB5A099 for ; Wed, 23 Feb 2022 15:37:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645659427; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T4uZUFplVlE5Y8frdrAqmVb5e+dpaoHXAN39OVRnAh4=; b=HfvT7Km9xEzosgW97guxKGspVDkjt76JZH5i66eL0dZz+5SAiA89HX/SFfSMixfdbkUm9/ R7JL5Qr89KYMQccOueAEwl2IQj2VVwk1PkhhUBlSmq4bS+8bM/H7kC18jbKblhgpge/qDb 9aWlteAKioJ7b1PZ3bjUdTgWo2Q00V0= Received: from mail-oi1-f198.google.com (mail-oi1-f198.google.com [209.85.167.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-562-NN3u76mAOmK4T-hsAZw3cw-1; Wed, 23 Feb 2022 18:37:06 -0500 X-MC-Unique: NN3u76mAOmK4T-hsAZw3cw-1 Received: by mail-oi1-f198.google.com with SMTP id be8-20020a056808218800b002d5425fab8cso354165oib.1 for ; Wed, 23 Feb 2022 15:37:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=T4uZUFplVlE5Y8frdrAqmVb5e+dpaoHXAN39OVRnAh4=; b=IQsNfOMAT5bpg/NhlHcaFlI+ZDMSK30xLjDCsDKqdxefaIgsWVRwu2/MxzHuHlN/CW YyiI6/ZpqXulJx6xMayqBILEbHL85gwMk21BikLcVAgMG6QBXmacfNKVCRG3k5OHoNpV FJvifZREiKN7aufCeUb9+NG9+ToKU2PLHY+JB6KSmvi8HDm6WvitiV9JgBw6l+DTjSsc K+LZwDuQW484vHXQyaOpQIu1+bDhNuOo8F4zkLHsZL9+Y/CVvbT0fM/EE4AoiiRYntsi /ahS/IGy+ihbSCjT0qM+HQnqwdi5ga3Sd6rvX8aFhm8gUqN3eku+SZgq30fc3Y9jhB28 4i4g== X-Gm-Message-State: AOAM53227HZmGaDGEdCyGyjam5L0PkH9eUUYmEqwSYbr6FxjcrSEfxIY /fR0EtgOL3FdLXsCjtRFGjaCL8qoTEEjM8qkFMWhJjn5+G1uXsgKlKm4eyyl5eH9tU8ZamawY0n anV3coCwD6Xv/EHyiPRFwJJbM X-Received: by 2002:a9d:7016:0:b0:5af:157b:685 with SMTP id k22-20020a9d7016000000b005af157b0685mr10032otj.16.1645659425852; Wed, 23 Feb 2022 15:37:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJxofdQSoSC1/kDx6fUUcLtOCsSdUzQ0Bk8PapztMnNq1yES+yHaSrNxhft1rMXuy1CFcMCgtg== X-Received: by 2002:a9d:7016:0:b0:5af:157b:685 with SMTP id k22-20020a9d7016000000b005af157b0685mr10026otj.16.1645659425637; Wed, 23 Feb 2022 15:37:05 -0800 (PST) Received: from redhat.com ([38.15.36.239]) by smtp.gmail.com with ESMTPSA id q73sm422469ooq.33.2022.02.23.15.37.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Feb 2022 15:37:05 -0800 (PST) Date: Wed, 23 Feb 2022 16:37:03 -0700 From: Alex Williamson To: Shameer Kolothum Cc: , , , , , , , , , , , Subject: Re: [PATCH v5 5/8] hisi_acc_vfio_pci: Restrict access to VF dev BAR2 migration region Message-ID: <20220223163703.20690b29.alex.williamson@redhat.com> In-Reply-To: <20220221114043.2030-6-shameerali.kolothum.thodi@huawei.com> References: <20220221114043.2030-1-shameerali.kolothum.thodi@huawei.com> <20220221114043.2030-6-shameerali.kolothum.thodi@huawei.com> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Feb 2022 11:40:40 +0000 Shameer Kolothum wrote: > > +static const struct vfio_device_ops hisi_acc_vfio_pci_migrn_ops = { > + .name = "hisi-acc-vfio-pci", Use a different name from the ops below? Thanks, Alex > + .open_device = hisi_acc_vfio_pci_open_device, > + .close_device = vfio_pci_core_close_device, > + .ioctl = hisi_acc_vfio_pci_ioctl, > + .device_feature = vfio_pci_core_ioctl_feature, > + .read = hisi_acc_vfio_pci_read, > + .write = hisi_acc_vfio_pci_write, > + .mmap = hisi_acc_vfio_pci_mmap, > + .request = vfio_pci_core_request, > + .match = vfio_pci_core_match, > +}; > + > static const struct vfio_device_ops hisi_acc_vfio_pci_ops = { > .name = "hisi-acc-vfio-pci", > .open_device = hisi_acc_vfio_pci_open_device,