From: Potin Lai <potin.lai@quantatw.com>
To: Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <jdelvare@suse.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>
Cc: Patrick Williams <patrick@stwcx.xyz>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, Potin Lai <potin.lai@quantatw.com>
Subject: [PATCH v2 1/2] hwmon: (adm1275) Allow setting sample averaging
Date: Thu, 24 Feb 2022 23:43:28 +0800 [thread overview]
Message-ID: <20220224154329.9755-2-potin.lai@quantatw.com> (raw)
In-Reply-To: <20220224154329.9755-1-potin.lai@quantatw.com>
Current driver assume PWR_AVG and VI_AVG as 1 by default, and user needs to
set sample averaging via sysfs manually.
This patch parses the properties below from device tree, and setting
sample averaging during probe.
- adi,power-sample-average
- adi,volt-curr-sample-average
Signed-off-by: Potin Lai <potin.lai@quantatw.com>
---
drivers/hwmon/pmbus/adm1275.c | 31 +++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/drivers/hwmon/pmbus/adm1275.c b/drivers/hwmon/pmbus/adm1275.c
index d311e0557401..4fc1421b7540 100644
--- a/drivers/hwmon/pmbus/adm1275.c
+++ b/drivers/hwmon/pmbus/adm1275.c
@@ -83,6 +83,8 @@ enum chips { adm1075, adm1272, adm1275, adm1276, adm1278, adm1293, adm1294 };
#define ADM1278_VI_AVG_MASK GENMASK(ADM1278_VI_AVG_SHIFT + 2, \
ADM1278_VI_AVG_SHIFT)
+#define ADM1275_SAMPLES_AVG_MAX_INDEX 7
+
struct adm1275_data {
int id;
bool have_oc_fault;
@@ -475,6 +477,7 @@ static int adm1275_probe(struct i2c_client *client)
int vindex = -1, voindex = -1, cindex = -1, pindex = -1;
int tindex = -1;
u32 shunt;
+ u8 avgindex;
if (!i2c_check_functionality(client->adapter,
I2C_FUNC_SMBUS_READ_BYTE_DATA
@@ -756,6 +759,34 @@ static int adm1275_probe(struct i2c_client *client)
return -ENODEV;
}
+ if (data->have_power_sampling &&
+ of_property_read_u8(client->dev.of_node,
+ "adi,power-sample-average", &avgindex) == 0) {
+ if (avgindex > ADM1275_SAMPLES_AVG_MAX_INDEX)
+ return -EINVAL;
+ ret = adm1275_write_pmon_config(data, client, true, avgindex);
+ if (ret < 0) {
+ dev_err(&client->dev,
+ "Setting power sample averaging failed with error %d",
+ ret);
+ return ret;
+ }
+ }
+
+ if (of_property_read_u8(client->dev.of_node,
+ "adi,volt-curr-sample-average",
+ &avgindex) == 0) {
+ if (avgindex > ADM1275_SAMPLES_AVG_MAX_INDEX)
+ return -EINVAL;
+ ret = adm1275_write_pmon_config(data, client, false, avgindex);
+ if (ret < 0) {
+ dev_err(&client->dev,
+ "Setting voltage and current sample averaging failed with error %d",
+ ret);
+ return ret;
+ }
+ }
+
if (voindex < 0)
voindex = vindex;
if (vindex >= 0) {
--
2.17.1
next prev parent reply other threads:[~2022-02-24 15:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 15:43 [PATCH v2 0/2] wmon: (adm1275) Add sample averaging binding support Potin Lai
2022-02-24 15:43 ` Potin Lai [this message]
2022-02-24 15:43 ` [PATCH v2 2/2] dt-bindings: hwmon: Add sample averaging property for ADM1275 Potin Lai
2022-02-25 7:06 ` Krzysztof Kozlowski
2022-02-25 7:31 ` Krzysztof Kozlowski
2022-02-25 8:41 ` Guenter Roeck
2022-02-25 8:56 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220224154329.9755-2-potin.lai@quantatw.com \
--to=potin.lai@quantatw.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzk@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=patrick@stwcx.xyz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®