From: Hangyu Hua <hbh25y@gmail.com>
To: wg@grandegger.com, mkl@pengutronix.de, davem@davemloft.net,
kuba@kernel.org, stefan.maetje@esd.eu,
mailhol.vincent@wanadoo.fr, paskripkin@gmail.com,
thunder.leizhen@huawei.com
Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Hangyu Hua <hbh25y@gmail.com>
Subject: [PATCH] can: usb: fix a possible memory leak in esd_usb2_start_xmit
Date: Fri, 25 Feb 2022 14:00:19 +0800 [thread overview]
Message-ID: <20220225060019.21220-1-hbh25y@gmail.com> (raw)
As in case of ems_usb_start_xmit, dev_kfree_skb needs to be called when
usb_submit_urb fails to avoid possible refcount leaks.
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
---
drivers/net/can/usb/esd_usb2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/can/usb/esd_usb2.c b/drivers/net/can/usb/esd_usb2.c
index 286daaaea0b8..7b5e6c250d00 100644
--- a/drivers/net/can/usb/esd_usb2.c
+++ b/drivers/net/can/usb/esd_usb2.c
@@ -810,7 +810,7 @@ static netdev_tx_t esd_usb2_start_xmit(struct sk_buff *skb,
usb_unanchor_urb(urb);
stats->tx_dropped++;
-
+ dev_kfree_skb(skb);
if (err == -ENODEV)
netif_device_detach(netdev);
else
--
2.25.1
next reply other threads:[~2022-02-25 6:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 6:00 Hangyu Hua [this message]
2022-02-25 15:56 ` Marc Kleine-Budde
2022-02-28 2:05 ` Hangyu Hua
2022-02-28 7:51 ` Marc Kleine-Budde
2022-02-28 8:06 ` Hangyu Hua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220225060019.21220-1-hbh25y@gmail.com \
--to=hbh25y@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=paskripkin@gmail.com \
--cc=stefan.maetje@esd.eu \
--cc=thunder.leizhen@huawei.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®