From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9953EC433EF for ; Sat, 26 Feb 2022 22:25:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229875AbiBZWZm (ORCPT ); Sat, 26 Feb 2022 17:25:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229802AbiBZWZi (ORCPT ); Sat, 26 Feb 2022 17:25:38 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8127208337 for ; Sat, 26 Feb 2022 14:25:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:In-Reply-To:References; bh=5p/YPWMCn5kchMlAEAoRn7rSjWDsO1V+22sdIn//plU=; b=oGcJNTovnzAIL1qn8AXDqs2dJu 9twjS9o9vcEKr/YC3oSy1+u/INQ6AZ7G5eaYs3QSVlOHjxb/Rbbmic35FThgRmC/pAU+J4vU3BhkR QBJvCN1c4R6UvfktTpd+d8Mu/QWt7N9LQdx8IIJUFDGF4JjQ3c6REUG7VIdhhjEdpcb9XMXYWnG2x 9+ZMlKCKzrfNbrcuhD3/peIEiQwtI3EuYiNaIQV+CaKNAooUxIsaGzUunvuhbbHTkewxHSlu7GpkP Lut1d56eqwo08BYy/Fy/YIAHywcgrifVaXzaLcAgbNnsIC3njs5Mm9sgsGKzLEf7k82y6sOG9DmtP Sc8hvuYw==; Received: from [2601:1c0:6280:3f0::aa0b] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nO5Uo-008ble-QN; Sat, 26 Feb 2022 22:24:58 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Wei WANG , Kai-Heng Feng , Greg Kroah-Hartman , Arnd Bergmann Subject: [PATCH -next] misc: rtsx: fix build for CONFIG_PM not set Date: Sat, 26 Feb 2022 14:24:57 -0800 Message-Id: <20220226222457.13668-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When CONFG_WERROR=y and CONFIG_PM is not set, there are fatal build errors, so surround these functions in an #ifdef CONFIG_PM block. ../drivers/misc/cardreader/rtsx_pcr.c:1057:13: error: ‘rtsx_enable_aspm’ defined but not used [-Werror=unused-function] static void rtsx_enable_aspm(struct rtsx_pcr *pcr) miscread001.out:../drivers/misc/cardreader/rtsx_pcr.c:1065:13: error: ‘rtsx_comm_pm_power_saving’ defined but not used [-Werror=unused-function] miscread001.out: static void rtsx_comm_pm_power_saving(struct rtsx_pcr *pcr) ../drivers/misc/cardreader/rtsx_pcr.c:1084:13: error: ‘rtsx_pm_power_saving’ defined but not used [-Werror=unused-function] static void rtsx_pm_power_saving(struct rtsx_pcr *pcr) Fixes: 597568e8df04 ("misc: rtsx: Rework runtime power management flow") Signed-off-by: Randy Dunlap Cc: Wei WANG Cc: Kai-Heng Feng Cc: Greg Kroah-Hartman Cc: Arnd Bergmann --- drivers/misc/cardreader/rtsx_pcr.c | 2 ++ 1 file changed, 2 insertions(+) --- linux-next-20220225.orig/drivers/misc/cardreader/rtsx_pcr.c +++ linux-next-20220225/drivers/misc/cardreader/rtsx_pcr.c @@ -1054,6 +1054,7 @@ static int rtsx_pci_acquire_irq(struct r return 0; } +#ifdef CONFIG_PM static void rtsx_enable_aspm(struct rtsx_pcr *pcr) { if (pcr->ops->set_aspm) @@ -1085,6 +1086,7 @@ static void rtsx_pm_power_saving(struct { rtsx_comm_pm_power_saving(pcr); } +#endif static void rtsx_base_force_power_down(struct rtsx_pcr *pcr) {