From: Meng Tang <tangmeng@uniontech.com>
To: perex@perex.cz, tiwai@suse.com
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Meng Tang <tangmeng@uniontech.com>
Subject: [PATCH 2/2] ALSA: core: Remove redundant 'err' variable
Date: Sun, 27 Feb 2022 15:12:53 +0800 [thread overview]
Message-ID: <20220227071253.28193-2-tangmeng@uniontech.com> (raw)
In-Reply-To: <20220227071253.28193-1-tangmeng@uniontech.com>
Return the result from file->f_op->open() directly instead of
taking this in another redundant variable.
Signed-off-by: Meng Tang <tangmeng@uniontech.com>
---
sound/sound_core.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/sound/sound_core.c b/sound/sound_core.c
index 2ee54070b2b5..e7fa820b08be 100644
--- a/sound/sound_core.c
+++ b/sound/sound_core.c
@@ -586,13 +586,12 @@ static int soundcore_open(struct inode *inode, struct file *file)
* We rely upon the fact that we can't be unloaded while the
* subdriver is there.
*/
- int err = 0;
replace_fops(file, new_fops);
if (file->f_op->open)
- err = file->f_op->open(inode,file);
+ return file->f_op->open(inode, file);
- return err;
+ return 0;
}
return -ENODEV;
}
--
2.20.1
next prev parent reply other threads:[~2022-02-27 7:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-27 7:12 [PATCH 1/2] ALSA: core: remove initialise static variables to 0 Meng Tang
2022-02-27 7:12 ` Meng Tang [this message]
2022-02-27 7:47 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220227071253.28193-2-tangmeng@uniontech.com \
--to=tangmeng@uniontech.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®