mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hangyu Hua <hbh25y@gmail.com>
To: gregkh@linuxfoundation.org
Cc: stable@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org, ben@decadent.org.uk,
	balbi@kernel.org, axboe@kernel.dk, mingo@kernel.org,
	jj251510319013@gmail.com, zsm@chromium.org,
	stern@rowland.harvard.edu, Hangyu Hua <hbh25y@gmail.com>
Subject: [PATCH 4.14 0/2] usb: gadget: use after free in dev_config
Date: Tue,  1 Mar 2022 10:26:06 +0800	[thread overview]
Message-ID: <20220301022608.10950-1-hbh25y@gmail.com> (raw)

Author: Hangyu Hua <hbh25y@gmail.com>
commit 89f3594d0de5 ("usb: gadget: don't release an existing dev->buf")

Author: Hangyu Hua <hbh25y@gmail.com>
commit 501e38a5531e ("usb: gadget: clear related members when goto fail")

Add two commits to all stable branches.

There are two bugs:
dev->buf does not need to be released if it already exists before
executing dev_config.
dev->config and dev->hs_config and dev->dev need to be cleaned if
dev_config fails to avoid UAF.

Hangyu Hua (2):
  usb: gadget: don't release an existing dev->buf
  usb: gadget: clear related members when goto fail

 drivers/usb/gadget/legacy/inode.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

-- 
2.25.1


             reply	other threads:[~2022-03-01  2:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-01  2:26 Hangyu Hua [this message]
2022-03-01  2:26 ` [PATCH 4.14 1/2] usb: gadget: don't release an existing dev->buf Hangyu Hua
2022-03-01  2:26 ` [PATCH 4.14 2/2] usb: gadget: clear related members when goto fail Hangyu Hua

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220301022608.10950-1-hbh25y@gmail.com \
    --to=hbh25y@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=balbi@kernel.org \
    --cc=ben@decadent.org.uk \
    --cc=gregkh@linuxfoundation.org \
    --cc=jj251510319013@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=zsm@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®