From: Miaoqian Lin <linmq006@gmail.com>
To: Eugen Hristev <eugen.hristev@microchip.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: linmq006@gmail.com
Subject: [PATCH v2] media: atmel: atmel-isc: Fix PM disable depth imbalance in atmel_isc_probe
Date: Tue, 1 Mar 2022 07:18:59 +0000 [thread overview]
Message-ID: <20220301071859.24285-1-linmq006@gmail.com> (raw)
In-Reply-To: <20220105111056.4662-1-linmq006@gmail.com>
The pm_runtime_enable will increase power disable depth.
If the probe fails, we should use pm_runtime_disable() to balance
pm_runtime_enable().
Fixes: 0a0e265 ("media: atmel: atmel-isc: split driver into driver base and isc")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
changes in v2:
- remove unused label.
---
drivers/media/platform/atmel/atmel-sama5d2-isc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/platform/atmel/atmel-sama5d2-isc.c b/drivers/media/platform/atmel/atmel-sama5d2-isc.c
index 1b2063cce0f7..7f1ebbb25437 100644
--- a/drivers/media/platform/atmel/atmel-sama5d2-isc.c
+++ b/drivers/media/platform/atmel/atmel-sama5d2-isc.c
@@ -559,6 +559,8 @@ static int atmel_isc_probe(struct platform_device *pdev)
cleanup_subdev:
isc_subdev_cleanup(isc);
+ pm_runtime_disable(dev);
+
unregister_v4l2_device:
v4l2_device_unregister(&isc->v4l2_dev);
--
2.17.1
next prev parent reply other threads:[~2022-03-01 7:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 11:10 [PATCH] " Miaoqian Lin
2022-01-06 12:42 ` kernel test robot
2022-03-01 7:18 ` Miaoqian Lin [this message]
2022-03-01 13:51 ` [PATCH v2] " Eugen.Hristev
2022-03-02 5:44 ` Miaoqian Lin
2022-03-02 6:17 ` Eugen.Hristev
2022-03-07 7:38 ` Hans Verkuil
2022-03-07 8:16 ` [PATCH v3] " Miaoqian Lin
2022-05-09 19:13 ` Eugen.Hristev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220301071859.24285-1-linmq006@gmail.com \
--to=linmq006@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=eugen.hristev@microchip.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=mchehab@kernel.org \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®