From: Viresh Kumar <viresh.kumar@linaro.org>
To: Lukasz Luba <lukasz.luba@arm.com>
Cc: linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com,
rafael@kernel.org, daniel.lezcano@linaro.org, nm@ti.com,
sboyd@kernel.org, mka@chromium.org, dianders@chromium.org,
robh+dt@kernel.org, devicetree@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v4 0/4] Introduce "opp-microwatt" and Energy Model from DT
Date: Wed, 2 Mar 2022 10:23:41 +0530 [thread overview]
Message-ID: <20220302045341.uzdflllpj7d55ekb@vireshk-i7> (raw)
In-Reply-To: <20220301093524.8870-1-lukasz.luba@arm.com>
On 01-03-22, 09:35, Lukasz Luba wrote:
> Hi all,
>
> This patch set solves a few issues:
> 1. It allows to register EM from DT, when the voltage information is not
> available. (Some background of the issues present on Chromebook devices
> can be checked at [1].)
> 2. It allows to register 'advanced' EM from the DT, which is more accurate
> and reflects total power (dynamic + static).
>
> Implementation details:
> Existing machinery in the OPP framework now handles "opp-microwatt", similarly
> to "opp-microamp". It also has helper exported function to get power from OPP.
> For the EM, it adds a new callback in OPP framework to use this new API and
> read power while having an opp pointer. It's agreed to work with OPP-v2.
>
> Comments, suggestions are very welcome.
>
> changelog:
> v4:
> - changed calculation of power, summing add all supliers power for an opp
> - added opp debugfs for u_watt
> - added patternProperties in dt-bindings for this new opp-microwatt
> - changed the EM opp registration flow and used one EM api registration call
> - changed name of _get_opp_power() to _get_dt_power()
> - removed 'advanced' word from the new paragraph and content in EM doc changes
> v3 [2]
Apart from one minor things, the patchset looks fine now. Thanks for
considering the review comments :)
--
viresh
prev parent reply other threads:[~2022-03-02 4:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 9:35 Lukasz Luba
2022-03-01 9:35 ` [PATCH v4 1/4] dt-bindings: opp: Add "opp-microwatt" entry in the OPP Lukasz Luba
2022-03-01 9:35 ` [PATCH v4 2/4] OPP: Add "opp-microwatt" supporting code Lukasz Luba
2022-03-01 9:35 ` [PATCH v4 3/4] OPP: Add support of "opp-microwatt" for advanced EM registration Lukasz Luba
2022-03-01 16:58 ` kernel test robot
2022-03-01 17:53 ` Lukasz Luba
2022-03-02 4:53 ` Viresh Kumar
2022-03-02 7:01 ` Lukasz Luba
2022-03-02 7:45 ` Viresh Kumar
2022-03-02 8:50 ` Lukasz Luba
2022-03-02 9:30 ` Viresh Kumar
2022-03-02 9:37 ` Lukasz Luba
2022-03-01 9:35 ` [PATCH v4 4/4] Documentation: EM: Describe new registration method using DT Lukasz Luba
2022-03-02 4:53 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220302045341.uzdflllpj7d55ekb@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=mka@chromium.org \
--cc=nm@ti.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®