From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 194D3C433F5 for ; Wed, 2 Mar 2022 09:18:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240394AbiCBJTH (ORCPT ); Wed, 2 Mar 2022 04:19:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240382AbiCBJTE (ORCPT ); Wed, 2 Mar 2022 04:19:04 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B2497B0A4F for ; Wed, 2 Mar 2022 01:18:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646212700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/k2VmYz+o3cpXUbtVkQoEKWCQmbl907XuCsT2KacOa0=; b=cO5OoxyT2caVHLlewaweat7J6oMaf/TCCeT+5kQJJFlr0hxzeaPB3INCPcsIqmFG5kZBx/ fIa0/giYzMuE/zEDhVTAEJvA3wr7FjTorTyt8utvWi5dGyLLkn7jCFpjyjGmYlBGu7nHAh aBvKrBC0fRCxADiGabluT/WzDj2RQM0= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-623-oEX_l1SMPU219SUgXRnNUA-1; Wed, 02 Mar 2022 04:18:18 -0500 X-MC-Unique: oEX_l1SMPU219SUgXRnNUA-1 Received: by mail-qk1-f199.google.com with SMTP id i10-20020a05620a144a00b00648d4fa059dso733940qkl.0 for ; Wed, 02 Mar 2022 01:18:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/k2VmYz+o3cpXUbtVkQoEKWCQmbl907XuCsT2KacOa0=; b=zNJ9VUerNw6p9Ub9BiAIyY+6307TZs4rZI6rSvhxKJQfuknVF9Yl9BrVWPgoGv8VC1 loDo6ne7Ij2H8If9Q4RKqTDrgNPSz5KtizTG4aFN2RvBIETEtmuKVnqwTHSf9jqOnIBV O40GM2b3xB/p86VG2gjXGYO/NCQO5UtspkToBkF00YBI1p/RfPAWS/OlruIkeXHZWvtt IXLjVSmmgwE27txUzRqe/tlUdjez4a3pp4PiJZXEuAAdelZIy9UFa2VJZniHCVTedOF2 jyQkL8Nh3GmxVwkAITecToqpU5kpPHULXvn7l1bmQNdXKhdvKurm9ekdGt4kazeGG/w2 RuIw== X-Gm-Message-State: AOAM533+BTKhfwb8perylEByyJeKAIx266foD89/bFCzLcIRaKhUGDah wMRcB4lAf3ZCq4bLeJg9A+u+4oZuzYhedV+uv1Uk0LISZxhttgmteGMLRvJBHY0/tDrPg97XHPs nT93IUKZ1Gj2Ic20cp1ShG0RZ X-Received: by 2002:a0c:d991:0:b0:432:c0c0:a6c5 with SMTP id y17-20020a0cd991000000b00432c0c0a6c5mr16665688qvj.23.1646212697392; Wed, 02 Mar 2022 01:18:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJxjYadbC0ZzXIcUVFlYssKE6/+21ynY+c3z8ydk8SARiLY20dVrDd2uNAQv/wlX6S8u2FOpWQ== X-Received: by 2002:a0c:d991:0:b0:432:c0c0:a6c5 with SMTP id y17-20020a0cd991000000b00432c0c0a6c5mr16665675qvj.23.1646212697118; Wed, 02 Mar 2022 01:18:17 -0800 (PST) Received: from sgarzare-redhat (host-95-248-229-156.retail.telecomitalia.it. [95.248.229.156]) by smtp.gmail.com with ESMTPSA id f7-20020a05622a104700b002d4b318692esm10885790qte.31.2022.03.02.01.18.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 01:18:16 -0800 (PST) Date: Wed, 2 Mar 2022 10:18:07 +0100 From: Stefano Garzarella To: Lee Jones Cc: "Michael S. Tsirkin" , kvm@vger.kernel.org, syzbot , netdev@vger.kernel.org, syzkaller-bugs@googlegroups.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [syzbot] kernel BUG in vhost_get_vq_desc Message-ID: <20220302091807.uyo7ycd6yw6cx7hd@sgarzare-redhat> References: <00000000000070ac6505d7d9f7a8@google.com> <0000000000003b07b305d840b30f@google.com> <20220218063352-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 02, 2022 at 08:29:41AM +0000, Lee Jones wrote: >On Fri, 18 Feb 2022, Michael S. Tsirkin wrote: > >> On Thu, Feb 17, 2022 at 05:21:20PM -0800, syzbot wrote: >> > syzbot has found a reproducer for the following issue on: >> > >> > HEAD commit: f71077a4d84b Merge tag 'mmc-v5.17-rc1-2' of git://git.kern.. >> > git tree: upstream >> > console output: https://syzkaller.appspot.com/x/log.txt?x=104c04ca700000 >> > kernel config: https://syzkaller.appspot.com/x/.config?x=a78b064590b9f912 >> > dashboard link: https://syzkaller.appspot.com/bug?extid=3140b17cb44a7b174008 >> > compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 >> > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1362e232700000 >> > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=11373a6c700000 >> > >> > IMPORTANT: if you fix the issue, please add the following tag to the commit: >> > Reported-by: syzbot+3140b17cb44a7b174008@syzkaller.appspotmail.com >> > >> > ------------[ cut here ]------------ >> > kernel BUG at drivers/vhost/vhost.c:2335! >> > invalid opcode: 0000 [#1] PREEMPT SMP KASAN >> > CPU: 1 PID: 3597 Comm: vhost-3596 Not tainted 5.17.0-rc4-syzkaller-00054-gf71077a4d84b #0 >> > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 >> > RIP: 0010:vhost_get_vq_desc+0x1d43/0x22c0 drivers/vhost/vhost.c:2335 >> > Code: 00 00 00 48 c7 c6 20 2c 9d 8a 48 c7 c7 98 a6 8e 8d 48 89 ca 48 c1 e1 04 48 01 d9 e8 b7 59 28 fd e9 74 ff ff ff e8 5d c8 a1 fa <0f> 0b e8 56 c8 a1 fa 48 8b 54 24 18 48 b8 00 00 00 00 00 fc ff df >> > RSP: 0018:ffffc90001d1fb88 EFLAGS: 00010293 >> > RAX: 0000000000000000 RBX: 0000000000000001 RCX: 0000000000000000 >> > RDX: ffff8880234b0000 RSI: ffffffff86d715c3 RDI: 0000000000000003 >> > RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000001 >> > R10: ffffffff86d706bc R11: 0000000000000000 R12: ffff888072c24d68 >> > R13: 0000000000000000 R14: dffffc0000000000 R15: ffff888072c24bb0 >> > FS: 0000000000000000(0000) GS:ffff8880b9d00000(0000) knlGS:0000000000000000 >> > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >> > CR2: 0000000000000002 CR3: 000000007902c000 CR4: 00000000003506e0 >> > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 >> > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 >> > Call Trace: >> > >> > vhost_vsock_handle_tx_kick+0x277/0xa20 drivers/vhost/vsock.c:522 >> > vhost_worker+0x23d/0x3d0 drivers/vhost/vhost.c:372 >> > kthread+0x2e9/0x3a0 kernel/kthread.c:377 >> > ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:295 >> >> I don't see how this can trigger normally so I'm assuming >> another case of use after free. > >Yes, exactly. I think this issue is related to the issue fixed by this patch merged some days ago upstream: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a58da53ffd70294ebea8ecd0eb45fd0d74add9f9 > >I patched it. Please see: > >https://lore.kernel.org/all/20220302075421.2131221-1-lee.jones@linaro.org/T/#t > I'm not sure that patch is avoiding the issue. I'll reply to it. Thanks, Stefano