From: Guenter Roeck <linux@roeck-us.net>
To: Aashish Sharma <shraash@google.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
linux-kernel@vger.kernel.org, groeck@chromium.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: Fix no previous prototype error in drm_nomodeset.c
Date: Wed, 2 Mar 2022 22:24:01 -0800 [thread overview]
Message-ID: <20220303062401.GA3284490@roeck-us.net> (raw)
In-Reply-To: <20220302170902.752687-1-shraash@google.com>
On Wed, Mar 02, 2022 at 10:39:02PM +0530, Aashish Sharma wrote:
> Fix this kernel test robot error:
>
> drivers/gpu/drm/drm_nomodeset.c:8:6: error:
> no previous prototype for 'drm_firmware_drivers_only'
>
> Including drm_drv.h in drm_nomodeset.c which contains
> drm_firmware_drivers_only's declaration.
>
> Signed-off-by: Aashish Sharma <shraash@google.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/gpu/drm/drm_nomodeset.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/drm_nomodeset.c b/drivers/gpu/drm/drm_nomodeset.c
> index f3978d5bd3a1..9402deb4985f 100644
> --- a/drivers/gpu/drm/drm_nomodeset.c
> +++ b/drivers/gpu/drm/drm_nomodeset.c
> @@ -2,6 +2,7 @@
>
> #include <linux/module.h>
> #include <linux/types.h>
> +#include <drm/drm_drv.h>
>
> static bool drm_nomodeset;
>
> --
> 2.35.1.574.g5d30c73bfb-goog
>
prev parent reply other threads:[~2022-03-03 6:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 17:09 Aashish Sharma
2022-03-03 6:24 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220303062401.GA3284490@roeck-us.net \
--to=linux@roeck-us.net \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=shraash@google.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®