From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F100EC433EF for ; Fri, 4 Mar 2022 10:00:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238346AbiCDKBY (ORCPT ); Fri, 4 Mar 2022 05:01:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233200AbiCDKBP (ORCPT ); Fri, 4 Mar 2022 05:01:15 -0500 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBDBA19CCD0; Fri, 4 Mar 2022 02:00:26 -0800 (PST) Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2245iwps027365; Fri, 4 Mar 2022 04:00:12 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=PODMain02222019; bh=lwhVfdpuKKMBPiRws4X0H+QIchtAscw5Q6iMAm4osNM=; b=dCVRqSvX2d4AIxXLbYj4l//Ei2h6QReFxgPwDpCm8tvq5w2TsHMeragQ7bTLqBkg5OOp Ggdv7QFAGDakT0T0m5MFpN2Zc/ujnC6LYq6RkgvPX0DzVhuaDn/T47t7ZwytLqifGtSU 6dMB0oTBrUves0J3GiYFp471iDTMDBRx9yjriNwvnZL8TXLmdVfbi2OcomXr6HW1FwR9 r6+c7NyQ35Gk92SM6S0mgjVU509tZSkGnVtbpmQELuC8+rUC2ZbIj60d1tKnVACKHq85 HnKxSMCxLUOIKYoXuifzSXV4VLuz63asSKZJGvrvvrfsF+3CPZ4K43FzBD4XpMZDO3wO jw== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3ek4j3gs7t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Fri, 04 Mar 2022 04:00:12 -0600 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Fri, 4 Mar 2022 10:00:11 +0000 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.2375.18 via Frontend Transport; Fri, 4 Mar 2022 10:00:11 +0000 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 3A8247C; Fri, 4 Mar 2022 10:00:11 +0000 (UTC) Date: Fri, 4 Mar 2022 10:00:11 +0000 From: Charles Keepax To: Jiasheng Jiang CC: , , , Subject: Re: [PATCH v2] power: supply: Handle error for wm8350_register_irq Message-ID: <20220304100011.GU38351@ediswmail.ad.cirrus.com> References: <20220304015751.367280-1-jiasheng@iscas.ac.cn> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220304015751.367280-1-jiasheng@iscas.ac.cn> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-GUID: f2usVe643jZg99CYmGdpU4NV6__644Rq X-Proofpoint-ORIG-GUID: f2usVe643jZg99CYmGdpU4NV6__644Rq X-Proofpoint-Spam-Reason: safe Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 04, 2022 at 09:57:51AM +0800, Jiasheng Jiang wrote: > As the potential failure of the wm8350_register_irq(), > it should be better to check it and return error if fails. > Also, use 'free_' in order to avoid same code. > > Fixes: 14431aa0c5a4 ("power_supply: Add support for WM8350 PMU") > Signed-off-by: Jiasheng Jiang > --- Acked-by: Charles Keepax Thanks, Charles