From: Shakeel Butt <shakeelb@google.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.com>, Vlastimil Babka <vbabka@suse.cz>,
Nadav Amit <nadav.amit@gmail.com>,
David Hildenbrand <david@redhat.com>,
dgilbert@redhat.com, Mike Kravetz <mike.kravetz@oracle.com>,
linux-mm@kvack.org, linux-api@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: madvise: MADV_DONTNEED_LOCKED
Date: Fri, 4 Mar 2022 19:26:00 +0000 [thread overview]
Message-ID: <20220304192600.rvmgbg72aq6idooc@google.com> (raw)
In-Reply-To: <20220304171912.305060-1-hannes@cmpxchg.org>
On Fri, Mar 04, 2022 at 12:19:12PM -0500, Johannes Weiner wrote:
> MADV_DONTNEED historically rejects mlocked ranges, but with
> MLOCK_ONFAULT and MCL_ONFAULT allowing to mlock without populating,
> there are valid use cases for depopulating locked ranges as well.
> Users mlock memory to protect secrets. There are allocators for secure
> buffers that want in-use memory generally mlocked, but cleared and
> invalidated memory to give up the physical pages. This could be done
> with explicit munlock -> mlock calls on free -> alloc of course, but
> that adds two unnecessary syscalls, heavy mmap_sem write locks, vma
> splits and re-merges - only to get rid of the backing pages.
> Users also mlockall(MCL_ONFAULT) to suppress sustained paging, but are
> okay with on-demand initial population. It seems valid to selectively
> free some memory during the lifetime of such a process, without having
> to mess with its overall policy.
> Why add a separate flag? Isn't this a pretty niche usecase?
> - MADV_DONTNEED has been bailing on locked vmas forever. It's at least
> conceivable that someone, somewhere is relying on mlock to protect
> data from perhaps broader invalidation calls. Changing this behavior
> now could lead to quiet data corruption.
> - It also clarifies expectations around MADV_FREE and maybe
> MADV_REMOVE. It avoids the situation where one quietly behaves
> different than the others. MADV_FREE_LOCKED can be added later.
> - The combination of mlock() and madvise() in the first place is
> probably niche. But where it happens, I'd say that dropping pages
> from a locked region once they don't contain secrets or won't page
> anymore is much saner than relying on mlock to protect memory from
> speculative or errant invalidation calls. It's just that we can't
> change the default behavior because of the two previous points.
> Given that, an explicit new flag seems to make the most sense.
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
> Acked-by: Michal Hocko <mhocko@suse.com>
Reviewed-by: Shakeel Butt <shakeelb@google.com>
next prev parent reply other threads:[~2022-03-04 20:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 17:19 Johannes Weiner
2022-03-04 18:45 ` Mike Kravetz
2022-03-04 19:26 ` Shakeel Butt [this message]
2022-03-08 15:31 ` Vlastimil Babka
-- strict thread matches above, loose matches on Subject: below --
2022-03-03 21:29 Johannes Weiner
2022-03-03 21:35 ` Nadav Amit
2022-03-03 22:25 ` Johannes Weiner
2022-03-03 21:47 ` Johannes Weiner
2022-03-04 9:12 ` Michal Hocko
2022-03-04 13:08 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220304192600.rvmgbg72aq6idooc@google.com \
--to=shakeelb@google.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mike.kravetz@oracle.com \
--cc=nadav.amit@gmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®