From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3587C433EF for ; Mon, 7 Mar 2022 12:45:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242492AbiCGMqG (ORCPT ); Mon, 7 Mar 2022 07:46:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242483AbiCGMqD (ORCPT ); Mon, 7 Mar 2022 07:46:03 -0500 Received: from ssl.serverraum.org (ssl.serverraum.org [IPv6:2a01:4f8:151:8464::1:2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E56E44249E; Mon, 7 Mar 2022 04:45:08 -0800 (PST) Received: from mwalle01.kontron.local. (unknown [213.135.10.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id C308A2223A; Mon, 7 Mar 2022 13:45:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1646657107; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6sN0on+TklJLiMkk+8nKplqKWkNGHVbTBnp3A9FH6r0=; b=V9GNDxz53Qy/kbVDQrLya7ZyUsj8qit4bW/2dpZNhwhl8ThqfQvk5HeErfeqB5zwl9H9L7 Zn3QGEnOIA2H9B8aVBU3hTcebp75B6aNj6t/9dZLT2wzvPjA/TtD0ub//nKM85mwglNL0z mxvmUcNoSRbye3XnKid8Tx7ITD6lWdU= From: Michael Walle To: horatiu.vultur@microchip.com Cc: andriy.shevchenko@linux.intel.com, colin.foster@in-advantage.com, linus.walleij@linaro.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Walle Subject: Re: [PATCH v2 1/2] pinctrl: ocelot: Fix the pincfg resource. Date: Mon, 7 Mar 2022 13:45:01 +0100 Message-Id: <20220307124501.3487932-1-michael@walle.cc> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220304144432.3397621-2-horatiu.vultur@microchip.com> References: <20220304144432.3397621-2-horatiu.vultur@microchip.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > The pincfg resources are in the second memory resource. But the driver > still tries to access the first memory resource to get the pincfg. This > is wrong therefore fix to access the second memory resource. > > Reviewed-by: Colin Foster > Fixes: ad96111e658a95 ("pinctrl: ocelot: combine get resource and ioremap into single call") > Signed-off-by: Horatiu Vultur There is already this patch pending, which does exactly the same: https://lore.kernel.org/linux-gpio/20220216082020.981797-1-michael@walle.cc/ FWIW, there is also this one: https://lore.kernel.org/linux-gpio/20220216122727.1005041-1-michael@walle.cc/ -michael