From: Li Yang <leoyang.li@nxp.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Li Yang <leoyang.li@nxp.com>, linux-kernel@vger.kernel.org
Subject: [PATCH] memory: fsl_ifc: populate child nodes of buses and mfd devices
Date: Mon, 7 Mar 2022 14:41:18 -0600 [thread overview]
Message-ID: <20220307204118.19093-1-leoyang.li@nxp.com> (raw)
Commit 98f1323959b8 was trying to replace the "simple-bus" compatible
with explicit bus populate in the driver. But of_platform_populate()
only populates child nodes of ifc without populating child buses and
child mfd devices residing under ifc. Change it to
of_platform_default_populate() to fix the problem.
Fixes: 98f1323959b8 ("memory: fsl_ifc: populate child devices without relying on simple-bus")
Signed-off-by: Li Yang <leoyang.li@nxp.com>
---
drivers/memory/fsl_ifc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/memory/fsl_ifc.c b/drivers/memory/fsl_ifc.c
index 6e6de52bb82d..1604de863d41 100644
--- a/drivers/memory/fsl_ifc.c
+++ b/drivers/memory/fsl_ifc.c
@@ -290,8 +290,7 @@ static int fsl_ifc_ctrl_probe(struct platform_device *dev)
}
/* legacy dts may still use "simple-bus" compatible */
- ret = of_platform_populate(dev->dev.of_node, NULL, NULL,
- &dev->dev);
+ ret = of_platform_default_populate(dev->dev.of_node, NULL, &dev->dev);
if (ret)
goto err_free_nandirq;
--
2.25.1
next reply other threads:[~2022-03-07 20:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 20:41 Li Yang [this message]
2022-03-17 7:33 ` Krzysztof Kozlowski
2022-04-06 7:41 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220307204118.19093-1-leoyang.li@nxp.com \
--to=leoyang.li@nxp.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®