From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 172E6C433FE for ; Tue, 8 Mar 2022 08:44:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345074AbiCHIpo (ORCPT ); Tue, 8 Mar 2022 03:45:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235249AbiCHIpn (ORCPT ); Tue, 8 Mar 2022 03:45:43 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 657343DDD7 for ; Tue, 8 Mar 2022 00:44:47 -0800 (PST) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nRVSD-0004uE-Rn; Tue, 08 Mar 2022 09:44:25 +0100 Received: from mtr by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nRVSC-0005PI-4E; Tue, 08 Mar 2022 09:44:24 +0100 Date: Tue, 8 Mar 2022 09:44:24 +0100 From: Michael Tretter To: Jia-Ju Bai Cc: vkoul@kernel.org, michal.simek@xilinx.com, lars@metafoo.de, libaokun1@huawei.com, yukuai3@huawei.com, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] dma: xilinx: check the return value of dma_set_mask() in zynqmp_dma_probe() Message-ID: <20220308084424.GC26648@pengutronix.de> References: <20220305093120.28999-1-baijiaju1990@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220305093120.28999-1-baijiaju1990@gmail.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:42:40 up 87 days, 17:28, 80 users, load average: 0.52, 0.44, 0.27 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mtr@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 05 Mar 2022 01:31:20 -0800, Jia-Ju Bai wrote: > The function dma_set_mask() in zynqmp_dma_probe() can fail, so its > return value should be checked. > > Fixes: b0cc417c1637 ("dmaengine: Add Xilinx zynqmp dma engine driver support") > Reported-by: TOTE Robot > Signed-off-by: Jia-Ju Bai Reviewed-by: Michael Tretter > --- > v2: > * Print an error message and forward the return value of dma_set_mask(). > Thank Michael for good advice. > > --- > drivers/dma/xilinx/zynqmp_dma.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c > index 7aa63b652027..2791e9c6a4ea 100644 > --- a/drivers/dma/xilinx/zynqmp_dma.c > +++ b/drivers/dma/xilinx/zynqmp_dma.c > @@ -1050,7 +1050,10 @@ static int zynqmp_dma_probe(struct platform_device *pdev) > zdev->dev = &pdev->dev; > INIT_LIST_HEAD(&zdev->common.channels); > > - dma_set_mask(&pdev->dev, DMA_BIT_MASK(44)); > + ret = dma_set_mask(&pdev->dev, DMA_BIT_MASK(44)); > + if (ret) > + return dev_err_probe(&pdev->dev, ret, "No usable DMA available\n"); > + > dma_cap_set(DMA_MEMCPY, zdev->common.cap_mask); > > p = &zdev->common; > -- > 2.17.1 > >