From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8D58C4332F for ; Tue, 8 Mar 2022 08:49:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345139AbiCHIuT (ORCPT ); Tue, 8 Mar 2022 03:50:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345131AbiCHIuQ (ORCPT ); Tue, 8 Mar 2022 03:50:16 -0500 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 652FE38D9F for ; Tue, 8 Mar 2022 00:49:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646729359; x=1678265359; h=date:from:to:cc:subject:message-id:mime-version; bh=qsteN1dFnRw0FxjE67Ns3g6dtAFfbNoZEA7OQLmJSkY=; b=V+7jgOGIF1as3KbGhaDS9A43lkouMlRS6vzjVZXMMIbPZezjRmA+qtXE EMI53WNSpzAxBfB72zYNnA3W8KBCRLUdEuLUnna5vExrJ6PMR9JFdzT1w r9c44wEL/51H2OdsFET4iMn6qU5aAc9vam0FuwQQCE9TLUl80maDU40bn S3STjcqYqHCd2lOVhprCNJcaoncJ75notj2X7y4dOJ2yt7bV0YXo61Nb1 d2GOHrrV3D+DfSIVOT1n/AbyS6Ij9Qd+MVUU8QvQfgOh2W4uFUy76NYk1 tyAIXA5actj0XPsdL5zEbWCxNupJ+6wVJ5/6zxBUCN860DGab2dtIRbs+ w==; X-IronPort-AV: E=McAfee;i="6200,9189,10279"; a="279344838" X-IronPort-AV: E=Sophos;i="5.90,164,1643702400"; d="scan'208";a="279344838" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2022 00:49:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,164,1643702400"; d="scan'208";a="495380688" Received: from lkp-server02.sh.intel.com (HELO 89b41b6ae01c) ([10.239.97.151]) by orsmga003.jf.intel.com with ESMTP; 08 Mar 2022 00:49:17 -0800 Received: from kbuild by 89b41b6ae01c with local (Exim 4.92) (envelope-from ) id 1nRVWu-0001AE-IA; Tue, 08 Mar 2022 08:49:16 +0000 Date: Tue, 8 Mar 2022 16:48:41 +0800 From: kernel test robot To: Eric Biggers Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org Subject: [ebiggers:testing 7/7] fs/iomap/direct-io.c:318:8: error: no member named 'bi_write_hint' in 'struct bio' Message-ID: <202203081630.wdYO0IZw-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org tree: https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git testing head: 236f1f551e0af2da4cbfe428d92361244534b1f3 commit: 236f1f551e0af2da4cbfe428d92361244534b1f3 [7/7] Merge remote-tracking branch 'fscrypt/master' into testing config: hexagon-randconfig-r041-20220307 (https://download.01.org/0day-ci/archive/20220308/202203081630.wdYO0IZw-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/commit/?id=236f1f551e0af2da4cbfe428d92361244534b1f3 git remote add ebiggers https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git git fetch --no-tags ebiggers testing git checkout 236f1f551e0af2da4cbfe428d92361244534b1f3 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash fs/iomap/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): >> fs/iomap/direct-io.c:318:8: error: no member named 'bi_write_hint' in 'struct bio' bio->bi_write_hint = dio->iocb->ki_hint; ~~~ ^ 1 error generated. vim +318 fs/iomap/direct-io.c c3b0e880bbfafa Naohiro Aota 2021-02-04 227 a6d3d49587d10d Christoph Hellwig 2021-08-10 228 static loff_t iomap_dio_bio_iter(const struct iomap_iter *iter, a6d3d49587d10d Christoph Hellwig 2021-08-10 229 struct iomap_dio *dio) db074436f42196 Darrick J. Wong 2019-07-15 230 { a6d3d49587d10d Christoph Hellwig 2021-08-10 231 const struct iomap *iomap = &iter->iomap; a6d3d49587d10d Christoph Hellwig 2021-08-10 232 struct inode *inode = iter->inode; db074436f42196 Darrick J. Wong 2019-07-15 233 unsigned int blkbits = blksize_bits(bdev_logical_block_size(iomap->bdev)); db074436f42196 Darrick J. Wong 2019-07-15 234 unsigned int fs_block_size = i_blocksize(inode), pad; db074436f42196 Darrick J. Wong 2019-07-15 235 unsigned int align = iov_iter_alignment(dio->submit.iter); a6d3d49587d10d Christoph Hellwig 2021-08-10 236 loff_t length = iomap_length(iter); a6d3d49587d10d Christoph Hellwig 2021-08-10 237 loff_t pos = iter->pos; c3b0e880bbfafa Naohiro Aota 2021-02-04 238 unsigned int bio_opf; db074436f42196 Darrick J. Wong 2019-07-15 239 struct bio *bio; db074436f42196 Darrick J. Wong 2019-07-15 240 bool need_zeroout = false; db074436f42196 Darrick J. Wong 2019-07-15 241 bool use_fua = false; db074436f42196 Darrick J. Wong 2019-07-15 242 int nr_pages, ret = 0; db074436f42196 Darrick J. Wong 2019-07-15 243 size_t copied = 0; f550ee9b85fd47 Jan Kara 2019-11-26 244 size_t orig_count; db074436f42196 Darrick J. Wong 2019-07-15 245 db074436f42196 Darrick J. Wong 2019-07-15 246 if ((pos | length | align) & ((1 << blkbits) - 1)) db074436f42196 Darrick J. Wong 2019-07-15 247 return -EINVAL; db074436f42196 Darrick J. Wong 2019-07-15 248 db074436f42196 Darrick J. Wong 2019-07-15 249 if (iomap->type == IOMAP_UNWRITTEN) { db074436f42196 Darrick J. Wong 2019-07-15 250 dio->flags |= IOMAP_DIO_UNWRITTEN; db074436f42196 Darrick J. Wong 2019-07-15 251 need_zeroout = true; db074436f42196 Darrick J. Wong 2019-07-15 252 } db074436f42196 Darrick J. Wong 2019-07-15 253 db074436f42196 Darrick J. Wong 2019-07-15 254 if (iomap->flags & IOMAP_F_SHARED) db074436f42196 Darrick J. Wong 2019-07-15 255 dio->flags |= IOMAP_DIO_COW; db074436f42196 Darrick J. Wong 2019-07-15 256 db074436f42196 Darrick J. Wong 2019-07-15 257 if (iomap->flags & IOMAP_F_NEW) { db074436f42196 Darrick J. Wong 2019-07-15 258 need_zeroout = true; db074436f42196 Darrick J. Wong 2019-07-15 259 } else if (iomap->type == IOMAP_MAPPED) { db074436f42196 Darrick J. Wong 2019-07-15 260 /* db074436f42196 Darrick J. Wong 2019-07-15 261 * Use a FUA write if we need datasync semantics, this is a pure db074436f42196 Darrick J. Wong 2019-07-15 262 * data IO that doesn't require any metadata updates (including db074436f42196 Darrick J. Wong 2019-07-15 263 * after IO completion such as unwritten extent conversion) and db074436f42196 Darrick J. Wong 2019-07-15 264 * the underlying device supports FUA. This allows us to avoid db074436f42196 Darrick J. Wong 2019-07-15 265 * cache flushes on IO completion. db074436f42196 Darrick J. Wong 2019-07-15 266 */ db074436f42196 Darrick J. Wong 2019-07-15 267 if (!(iomap->flags & (IOMAP_F_SHARED|IOMAP_F_DIRTY)) && db074436f42196 Darrick J. Wong 2019-07-15 268 (dio->flags & IOMAP_DIO_WRITE_FUA) && db074436f42196 Darrick J. Wong 2019-07-15 269 blk_queue_fua(bdev_get_queue(iomap->bdev))) db074436f42196 Darrick J. Wong 2019-07-15 270 use_fua = true; db074436f42196 Darrick J. Wong 2019-07-15 271 } db074436f42196 Darrick J. Wong 2019-07-15 272 db074436f42196 Darrick J. Wong 2019-07-15 273 /* f550ee9b85fd47 Jan Kara 2019-11-26 274 * Save the original count and trim the iter to just the extent we f550ee9b85fd47 Jan Kara 2019-11-26 275 * are operating on right now. The iter will be re-expanded once f550ee9b85fd47 Jan Kara 2019-11-26 276 * we are done. db074436f42196 Darrick J. Wong 2019-07-15 277 */ f550ee9b85fd47 Jan Kara 2019-11-26 278 orig_count = iov_iter_count(dio->submit.iter); f550ee9b85fd47 Jan Kara 2019-11-26 279 iov_iter_truncate(dio->submit.iter, length); db074436f42196 Darrick J. Wong 2019-07-15 280 3e1a88ec962592 Pavel Begunkov 2021-01-09 281 if (!iov_iter_count(dio->submit.iter)) f550ee9b85fd47 Jan Kara 2019-11-26 282 goto out; db074436f42196 Darrick J. Wong 2019-07-15 283 f79d474905fec0 Christoph Hellwig 2021-10-12 284 /* f79d474905fec0 Christoph Hellwig 2021-10-12 285 * We can only poll for single bio I/Os. f79d474905fec0 Christoph Hellwig 2021-10-12 286 */ f79d474905fec0 Christoph Hellwig 2021-10-12 287 if (need_zeroout || f79d474905fec0 Christoph Hellwig 2021-10-12 288 ((dio->flags & IOMAP_DIO_WRITE) && pos >= i_size_read(inode))) f79d474905fec0 Christoph Hellwig 2021-10-12 289 dio->iocb->ki_flags &= ~IOCB_HIPRI; f79d474905fec0 Christoph Hellwig 2021-10-12 290 db074436f42196 Darrick J. Wong 2019-07-15 291 if (need_zeroout) { db074436f42196 Darrick J. Wong 2019-07-15 292 /* zero out from the start of the block to the write offset */ db074436f42196 Darrick J. Wong 2019-07-15 293 pad = pos & (fs_block_size - 1); db074436f42196 Darrick J. Wong 2019-07-15 294 if (pad) a6d3d49587d10d Christoph Hellwig 2021-08-10 295 iomap_dio_zero(iter, dio, pos - pad, pad); db074436f42196 Darrick J. Wong 2019-07-15 296 } db074436f42196 Darrick J. Wong 2019-07-15 297 c3b0e880bbfafa Naohiro Aota 2021-02-04 298 /* c3b0e880bbfafa Naohiro Aota 2021-02-04 299 * Set the operation flags early so that bio_iov_iter_get_pages c3b0e880bbfafa Naohiro Aota 2021-02-04 300 * can set up the page vector appropriately for a ZONE_APPEND c3b0e880bbfafa Naohiro Aota 2021-02-04 301 * operation. c3b0e880bbfafa Naohiro Aota 2021-02-04 302 */ c3b0e880bbfafa Naohiro Aota 2021-02-04 303 bio_opf = iomap_dio_bio_opflags(dio, iomap, use_fua); c3b0e880bbfafa Naohiro Aota 2021-02-04 304 a8affc03a9b375 Christoph Hellwig 2021-03-11 305 nr_pages = bio_iov_vecs_to_alloc(dio->submit.iter, BIO_MAX_VECS); db074436f42196 Darrick J. Wong 2019-07-15 306 do { db074436f42196 Darrick J. Wong 2019-07-15 307 size_t n; db074436f42196 Darrick J. Wong 2019-07-15 308 if (dio->error) { db074436f42196 Darrick J. Wong 2019-07-15 309 iov_iter_revert(dio->submit.iter, copied); f550ee9b85fd47 Jan Kara 2019-11-26 310 copied = ret = 0; f550ee9b85fd47 Jan Kara 2019-11-26 311 goto out; db074436f42196 Darrick J. Wong 2019-07-15 312 } db074436f42196 Darrick J. Wong 2019-07-15 313 07888c665b405b Christoph Hellwig 2022-01-24 314 bio = bio_alloc(iomap->bdev, nr_pages, bio_opf, GFP_KERNEL); 489734ef94f4f7 Eric Biggers 2022-01-28 315 fscrypt_set_bio_crypt_ctx(bio, inode, pos >> inode->i_blkbits, 489734ef94f4f7 Eric Biggers 2022-01-28 316 GFP_KERNEL); db074436f42196 Darrick J. Wong 2019-07-15 317 bio->bi_iter.bi_sector = iomap_sector(iomap, pos); db074436f42196 Darrick J. Wong 2019-07-15 @318 bio->bi_write_hint = dio->iocb->ki_hint; db074436f42196 Darrick J. Wong 2019-07-15 319 bio->bi_ioprio = dio->iocb->ki_ioprio; db074436f42196 Darrick J. Wong 2019-07-15 320 bio->bi_private = dio; db074436f42196 Darrick J. Wong 2019-07-15 321 bio->bi_end_io = iomap_dio_bio_end_io; db074436f42196 Darrick J. Wong 2019-07-15 322 f550ee9b85fd47 Jan Kara 2019-11-26 323 ret = bio_iov_iter_get_pages(bio, dio->submit.iter); db074436f42196 Darrick J. Wong 2019-07-15 324 if (unlikely(ret)) { db074436f42196 Darrick J. Wong 2019-07-15 325 /* db074436f42196 Darrick J. Wong 2019-07-15 326 * We have to stop part way through an IO. We must fall db074436f42196 Darrick J. Wong 2019-07-15 327 * through to the sub-block tail zeroing here, otherwise db074436f42196 Darrick J. Wong 2019-07-15 328 * this short IO may expose stale data in the tail of db074436f42196 Darrick J. Wong 2019-07-15 329 * the block we haven't written data to. db074436f42196 Darrick J. Wong 2019-07-15 330 */ db074436f42196 Darrick J. Wong 2019-07-15 331 bio_put(bio); db074436f42196 Darrick J. Wong 2019-07-15 332 goto zero_tail; db074436f42196 Darrick J. Wong 2019-07-15 333 } db074436f42196 Darrick J. Wong 2019-07-15 334 db074436f42196 Darrick J. Wong 2019-07-15 335 n = bio->bi_iter.bi_size; db074436f42196 Darrick J. Wong 2019-07-15 336 if (dio->flags & IOMAP_DIO_WRITE) { db074436f42196 Darrick J. Wong 2019-07-15 337 task_io_account_write(n); db074436f42196 Darrick J. Wong 2019-07-15 338 } else { db074436f42196 Darrick J. Wong 2019-07-15 339 if (dio->flags & IOMAP_DIO_DIRTY) db074436f42196 Darrick J. Wong 2019-07-15 340 bio_set_pages_dirty(bio); db074436f42196 Darrick J. Wong 2019-07-15 341 } db074436f42196 Darrick J. Wong 2019-07-15 342 db074436f42196 Darrick J. Wong 2019-07-15 343 dio->size += n; db074436f42196 Darrick J. Wong 2019-07-15 344 copied += n; db074436f42196 Darrick J. Wong 2019-07-15 345 3e1a88ec962592 Pavel Begunkov 2021-01-09 346 nr_pages = bio_iov_vecs_to_alloc(dio->submit.iter, a8affc03a9b375 Christoph Hellwig 2021-03-11 347 BIO_MAX_VECS); f79d474905fec0 Christoph Hellwig 2021-10-12 348 /* f79d474905fec0 Christoph Hellwig 2021-10-12 349 * We can only poll for single bio I/Os. f79d474905fec0 Christoph Hellwig 2021-10-12 350 */ f79d474905fec0 Christoph Hellwig 2021-10-12 351 if (nr_pages) f79d474905fec0 Christoph Hellwig 2021-10-12 352 dio->iocb->ki_flags &= ~IOCB_HIPRI; a6d3d49587d10d Christoph Hellwig 2021-08-10 353 iomap_dio_submit_bio(iter, dio, bio, pos); 8cecd0ba854799 Goldwyn Rodrigues 2019-05-14 354 pos += n; db074436f42196 Darrick J. Wong 2019-07-15 355 } while (nr_pages); db074436f42196 Darrick J. Wong 2019-07-15 356 db074436f42196 Darrick J. Wong 2019-07-15 357 /* db074436f42196 Darrick J. Wong 2019-07-15 358 * We need to zeroout the tail of a sub-block write if the extent type db074436f42196 Darrick J. Wong 2019-07-15 359 * requires zeroing or the write extends beyond EOF. If we don't zero db074436f42196 Darrick J. Wong 2019-07-15 360 * the block tail in the latter case, we can expose stale data via mmap db074436f42196 Darrick J. Wong 2019-07-15 361 * reads of the EOF block. db074436f42196 Darrick J. Wong 2019-07-15 362 */ db074436f42196 Darrick J. Wong 2019-07-15 363 zero_tail: db074436f42196 Darrick J. Wong 2019-07-15 364 if (need_zeroout || db074436f42196 Darrick J. Wong 2019-07-15 365 ((dio->flags & IOMAP_DIO_WRITE) && pos >= i_size_read(inode))) { db074436f42196 Darrick J. Wong 2019-07-15 366 /* zero out from the end of the write to the end of the block */ db074436f42196 Darrick J. Wong 2019-07-15 367 pad = pos & (fs_block_size - 1); db074436f42196 Darrick J. Wong 2019-07-15 368 if (pad) a6d3d49587d10d Christoph Hellwig 2021-08-10 369 iomap_dio_zero(iter, dio, pos, fs_block_size - pad); db074436f42196 Darrick J. Wong 2019-07-15 370 } f550ee9b85fd47 Jan Kara 2019-11-26 371 out: f550ee9b85fd47 Jan Kara 2019-11-26 372 /* Undo iter limitation to current extent */ f550ee9b85fd47 Jan Kara 2019-11-26 373 iov_iter_reexpand(dio->submit.iter, orig_count - copied); e9f930ac88a893 Jan Stancek 2019-11-11 374 if (copied) e9f930ac88a893 Jan Stancek 2019-11-11 375 return copied; e9f930ac88a893 Jan Stancek 2019-11-11 376 return ret; db074436f42196 Darrick J. Wong 2019-07-15 377 } db074436f42196 Darrick J. Wong 2019-07-15 378 :::::: The code at line 318 was first introduced by commit :::::: db074436f421967f4f30cfbb6fbc2a728f3e62b3 iomap: move the direct IO code into a separate file :::::: TO: Darrick J. Wong :::::: CC: Darrick J. Wong --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org