From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A96B0C433EF for ; Tue, 8 Mar 2022 17:10:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348506AbiCHRLi (ORCPT ); Tue, 8 Mar 2022 12:11:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231548AbiCHRLg (ORCPT ); Tue, 8 Mar 2022 12:11:36 -0500 Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0418136E1A; Tue, 8 Mar 2022 09:10:38 -0800 (PST) Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 228BoqLg031707; Tue, 8 Mar 2022 18:10:15 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=selector1; bh=XzG/zTVw2euF6p0nfQidx3eU2qleO7oEmiQIU/vSMww=; b=oYbXxQdaMgmV7JT3H83RsSSX7c1UQsb3ZPEH5iyScDvk3d+ZqexIgHCRvPUSkdfSErV0 eg9PtWlqggZoj5GeOLgbEs83+fJSa6a1mAjeB+vvekp7WW3XgfDBoaRLiqyxMRgVEfTf /4nDS9UfO5f/PokAQVUtNKkY07OH0yuj/ZCNkcxhBkocBAlVZf9csgS+y2GH4W6JrIRS AuF564DJJilikEgGWMVC/W1yprKE4PNDIk7UrkadGJVZDZ3tEteTJ/C0/WpusyhIHYW0 oqGAUhwgiQ7XCGf2cT6ba5CnE5PSUlOVlf68mlnbZnBDgdiDK8S85kD0SjkVYDt+Pjry ag== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3em0342jt1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 08 Mar 2022 18:10:15 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 4D84410002A; Tue, 8 Mar 2022 18:10:12 +0100 (CET) Received: from Webmail-eu.st.com (sfhdag2node2.st.com [10.75.127.5]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id BCEE523694E; Tue, 8 Mar 2022 18:10:12 +0100 (CET) Received: from gnbcxd0016.gnb.st.com (10.75.127.51) by SFHDAG2NODE2.st.com (10.75.127.5) with Microsoft SMTP Server (TLS) id 15.0.1497.26; Tue, 8 Mar 2022 18:10:12 +0100 Date: Tue, 8 Mar 2022 18:10:05 +0100 From: Alain Volmat To: Andy Shevchenko CC: Mauro Carvalho Chehab , , , , Patrice Chotard , Mauro Carvalho Chehab , Hans Verkuil Subject: Re: [PATCH v1 1/1] media: c8sectpfe: Clean up handling of *_buffer_aligned Message-ID: <20220308171005.GA365233@gnbcxd0016.gnb.st.com> Mail-Followup-To: Andy Shevchenko , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Patrice Chotard , Mauro Carvalho Chehab , Hans Verkuil References: <20220209182521.55632-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-Disclaimer: ce message est personnel / this message is private X-Originating-IP: [10.75.127.51] X-ClientProxiedBy: SFHDAG2NODE3.st.com (10.75.127.6) To SFHDAG2NODE2.st.com (10.75.127.5) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.64.514 definitions=2022-03-08_06,2022-03-04_01,2022-02-23_01 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy, sorry for the delay. Reviewed-by: Alain Volmat Regards, Alain On Tue, Mar 08, 2022 at 12:25:42PM +0200, Andy Shevchenko wrote: > +Hans (see below). > > On Wed, Mar 02, 2022 at 05:51:42PM +0200, Andy Shevchenko wrote: > > On Wed, Feb 09, 2022 at 08:25:21PM +0200, Andy Shevchenko wrote: > > > There are a few cases where code is harder than needed to read. > > > Improve those by: > > > - dropping unnecessary castings (see note below) > > > - use PTR_ALING() to be more explicit on what's going on there > > > - use proper definitions instead of hard coded values > > > > > > Note, dropping castings will allow to perform an additional check > > > that type is not changed from void * to something else, e.g. u64, > > > which may very well break the bitmap APIs. > > > > Any comments on it? > > Can it be applied? > > -- > With Best Regards, > Andy Shevchenko > >