From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87F53C35278 for ; Wed, 9 Mar 2022 16:50:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237514AbiCIQtP (ORCPT ); Wed, 9 Mar 2022 11:49:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239052AbiCIQcH (ORCPT ); Wed, 9 Mar 2022 11:32:07 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 893E81A8062; Wed, 9 Mar 2022 08:27:03 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CDE10619C9; Wed, 9 Mar 2022 16:26:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A458EC340F6; Wed, 9 Mar 2022 16:26:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646843205; bh=qkttfvUkMX8pixr/UYRauWVmlsHrV8EzgM73QaxlJqM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NVoZ3E1SPIW0yJb6kvvQ7aikwbffkEMDWEqoJVzLPwOEmC4EE1IKrCAE/mMa7ZVEx aerov6bJYZQjHS3/jCb/fueVM3EpAF0rVEasWBKA1paDlgpk9kSNMC3qWKJV9P6ROD v2wDhD0JietmmPtj72NgRziwlsOJaJrttfkfXrWEosxitsZwYtI+a+Rhfum37vWUTT 9WuVGKjAeUuTghBwIemuS2YwFziqhle91zfL0ARs7Gmq4m9gkeuDc9pyMB5jvVUqH5 fq4USasWLYbS5zW7Hfqn5Z268p8XgIqLJIAzpf2UAD+fWjoLNMfezL2/t2eRh/Yxff df1eP7ij8I+UQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Julian Braha , Russell King , Sasha Levin , jarkko@kernel.org, deller@gmx.de, johannes.berg@intel.com, James.Bottomley@HansenPartnership.com, mcroce@microsoft.com, arnd@arndb.de Subject: [PATCH AUTOSEL 4.14 05/12] ARM: 9178/1: fix unmet dependency on BITREVERSE for HAVE_ARCH_BITREVERSE Date: Wed, 9 Mar 2022 11:26:10 -0500 Message-Id: <20220309162618.137226-5-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220309162618.137226-1-sashal@kernel.org> References: <20220309162618.137226-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Julian Braha [ Upstream commit 11c57c3ba94da74c3446924260e34e0b1950b5d7 ] Resending this to properly add it to the patch tracker - thanks for letting me know, Arnd :) When ARM is enabled, and BITREVERSE is disabled, Kbuild gives the following warning: WARNING: unmet direct dependencies detected for HAVE_ARCH_BITREVERSE Depends on [n]: BITREVERSE [=n] Selected by [y]: - ARM [=y] && (CPU_32v7M [=n] || CPU_32v7 [=y]) && !CPU_32v6 [=n] This is because ARM selects HAVE_ARCH_BITREVERSE without selecting BITREVERSE, despite HAVE_ARCH_BITREVERSE depending on BITREVERSE. This unmet dependency bug was found by Kismet, a static analysis tool for Kconfig. Please advise if this is not the appropriate solution. Signed-off-by: Julian Braha Signed-off-by: Russell King (Oracle) Signed-off-by: Sasha Levin --- lib/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/Kconfig b/lib/Kconfig index 8396c4cfa1ab..1a33e9365951 100644 --- a/lib/Kconfig +++ b/lib/Kconfig @@ -16,7 +16,6 @@ config BITREVERSE config HAVE_ARCH_BITREVERSE bool default n - depends on BITREVERSE help This option enables the use of hardware bit-reversal instructions on architectures which support such operations. -- 2.34.1