From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E25F0C47082 for ; Wed, 9 Mar 2022 16:50:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237931AbiCIQuR (ORCPT ); Wed, 9 Mar 2022 11:50:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238287AbiCIQdE (ORCPT ); Wed, 9 Mar 2022 11:33:04 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 220771ACA34; Wed, 9 Mar 2022 08:28:39 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DAAFDB82253; Wed, 9 Mar 2022 16:27:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD382C340F5; Wed, 9 Mar 2022 16:27:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646843270; bh=IAO/tvgrD7m/QtcNZol25+fTlHitELFYA+SELj892+A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Gog77FEsD6LKI83wgLlAP7V/LDztXTzu0S+TTWQbc6gmZNsc8GyhvC3Xtq/LEs51p JVKLpLqXBwcMGY0f850iWdJDBAlbfW+QgDzq/xZbPwpze8zJ1QBWIVvLY+Xqaa1/I1 bTkv0URpa5gjhUZR7+hJC6+1wSslmI9nf/wTU6LifQ/DwQjNF8th5eKeJ5c+B/w1h7 Voi38jx2ze0JV5rzXV8+6J/eA2WJedsOk6G2SuhaP7KWGPD8G+1jVVKMXF6ip52qxw lyJg0higuYuM1Wowg7ae/nKJiuAhMLCKeP4AI0K3Iolah9fiCVvyfijSHQeWQs4Y8E MRFuhPuDm6dwQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jia-Ju Bai , TOTE Robot , "David S . Miller" , Sasha Levin , 3chas3@gmail.com, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 06/11] atm: firestream: check the return value of ioremap() in fs_init() Date: Wed, 9 Mar 2022 11:27:11 -0500 Message-Id: <20220309162716.137399-6-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220309162716.137399-1-sashal@kernel.org> References: <20220309162716.137399-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jia-Ju Bai [ Upstream commit d4e26aaea7f82ba884dcb4acfe689406bc092dc3 ] The function ioremap() in fs_init() can fail, so its return value should be checked. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/atm/firestream.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/atm/firestream.c b/drivers/atm/firestream.c index 7cb2b863e653..7d74b7e1a837 100644 --- a/drivers/atm/firestream.c +++ b/drivers/atm/firestream.c @@ -1692,6 +1692,8 @@ static int fs_init(struct fs_dev *dev) dev->hw_base = pci_resource_start(pci_dev, 0); dev->base = ioremap(dev->hw_base, 0x1000); + if (!dev->base) + return 1; reset_chip (dev); -- 2.34.1