From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B81E2C433F5 for ; Thu, 10 Mar 2022 01:10:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239068AbiCJBLq (ORCPT ); Wed, 9 Mar 2022 20:11:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229907AbiCJBLo (ORCPT ); Wed, 9 Mar 2022 20:11:44 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8B6211B5EF for ; Wed, 9 Mar 2022 17:10:44 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8D02B61345 for ; Thu, 10 Mar 2022 01:10:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D18C8C340E8; Thu, 10 Mar 2022 01:10:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1646874644; bh=7UE/AN7koc5W2DTwiCBq0htzqBHnnGLtGO4KphiksVM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=y4MtSYETuuIRHISJ6XVh0trr3P2h0vdi2iXe3L5P2ab7BJEHJfMJFXpBOaj8tm3X0 9vhZg/pLgOPqNsEqVaTgcCeOGc8QiSUdSTZzj0ymYBd2mCYnq6XQCnnOpLkab0ac2N SYCwIPyovs67dG80Jf/m+dstccFkHu+hod8vk1+w= Date: Wed, 9 Mar 2022 17:10:43 -0800 From: Andrew Morton To: Qian Cai Cc: , Daniel Thompson , Kees Cook Subject: Re: [PATCH] configs/debug: Restore DEBUG_INFO=y for overriding Message-Id: <20220309171043.33e048bb8bc43e5f483fa102@linux-foundation.org> In-Reply-To: <20220308153524.8618-1-quic_qiancai@quicinc.com> References: <20220308153524.8618-1-quic_qiancai@quicinc.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 8 Mar 2022 10:35:24 -0500 Qian Cai wrote: > Previously, I failed to realize that Kees' patch [1] has not been merged > into the mainline yet, and dropped DEBUG_INFO=y too eagerly from the > mainline. As the results, "make debug.config" won't be able to flip > DEBUG_INFO=n from the existing .config. This should close the gaps of a > few weeks before Kees' patch is there, and work regardless of their > merging status anyway. > > [1] https://lore.kernel.org/all/20220125075126.891825-1-keescook@chromium.org/ > > ... > > --- a/kernel/configs/debug.config > +++ b/kernel/configs/debug.config > @@ -16,6 +16,7 @@ CONFIG_SYMBOLIC_ERRNAME=y > # > # Compile-time checks and compiler options > # > +CONFIG_DEBUG_INFO=y > CONFIG_DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT=y > CONFIG_DEBUG_SECTION_MISMATCH=y > CONFIG_FRAME_WARN=2048 Thanks, I queued this for 5.17,