From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5726BC433EF for ; Thu, 10 Mar 2022 19:28:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343573AbiCJT3F (ORCPT ); Thu, 10 Mar 2022 14:29:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243566AbiCJT3A (ORCPT ); Thu, 10 Mar 2022 14:29:00 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A43F3EAA1 for ; Thu, 10 Mar 2022 11:27:58 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 17CC161154 for ; Thu, 10 Mar 2022 19:27:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 77A86C340E8; Thu, 10 Mar 2022 19:27:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646940477; bh=yTiicAe1GiprjsUYUFCzX3ycb9cWzOEx/0Zt7V7Jr/k=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=nPa+yPJxLdpQW9C/WpPwDgLJScjWDeCDUOn+0e3jEnk72Z3G0l0NjCuAC3PmBY/XF BWu9k1Ote2WsxFjvYOplOAQd81+33rPxyoGFwzrg9q3gLPtNDIlwFEWc4btF9gcPYV 3485T8U82vnb+WoHiNIl8bfCFcQk6NYX5GGSBNeiWUx64/yDLGvc87nPP+QDie/Mh3 bJGJcQFpysJsF+i+w/S6JzINP3a844/Vryhxt5rfzaqY90jhglJ8MFWihiHKvLnQy4 pncCePj/RSeBJCOsKX8tSBYhq4NAWumROOAiNalkt1zp4d08hlVRZFpdd+DjWh3Z// AWjSkjljHqLuA== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 22D6C5C0387; Thu, 10 Mar 2022 11:27:57 -0800 (PST) Date: Thu, 10 Mar 2022 11:27:57 -0800 From: "Paul E. McKenney" To: Frederic Weisbecker Cc: LKML , Peter Zijlstra , Phil Auld , Alex Belits , Nicolas Saenz Julienne , Xiongfeng Wang , Neeraj Upadhyay , Thomas Gleixner , Yu Liao , Boqun Feng , Marcelo Tosatti , Paul Gortmaker , Uladzislau Rezki , Joel Fernandes Subject: Re: [PATCH 01/19] context_tracking: Rename __context_tracking_enter/exit() to __ct_user_enter/exit() Message-ID: <20220310192757.GS4285@paulmck-ThinkPad-P17-Gen-1> Reply-To: paulmck@kernel.org References: <20220302154810.42308-1-frederic@kernel.org> <20220302154810.42308-2-frederic@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220302154810.42308-2-frederic@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 02, 2022 at 04:47:52PM +0100, Frederic Weisbecker wrote: > The context tracking namespace is going to expand and some new functions > will require even longer names. Start shrinking the context_tracking > prefix to "ct" as is already the case for some existing macros, this > will make the introduction of new functions easier. > > Signed-off-by: Frederic Weisbecker Acked-by: Paul E. McKenney > Cc: Paul E. McKenney > Cc: Peter Zijlstra > Cc: Thomas Gleixner > Cc: Neeraj Upadhyay > Cc: Uladzislau Rezki > Cc: Joel Fernandes > Cc: Boqun Feng > Cc: Nicolas Saenz Julienne > Cc: Marcelo Tosatti > Cc: Xiongfeng Wang > Cc: Yu Liao > Cc: Phil Auld > Cc: Paul Gortmaker > Cc: Alex Belits > --- > include/linux/context_tracking.h | 12 ++++++------ > kernel/context_tracking.c | 20 ++++++++++---------- > 2 files changed, 16 insertions(+), 16 deletions(-) > > diff --git a/include/linux/context_tracking.h b/include/linux/context_tracking.h > index 7a14807c9d1a..773035124bad 100644 > --- a/include/linux/context_tracking.h > +++ b/include/linux/context_tracking.h > @@ -14,8 +14,8 @@ > extern void context_tracking_cpu_set(int cpu); > > /* Called with interrupts disabled. */ > -extern void __context_tracking_enter(enum ctx_state state); > -extern void __context_tracking_exit(enum ctx_state state); > +extern void __ct_user_enter(enum ctx_state state); > +extern void __ct_user_exit(enum ctx_state state); > > extern void context_tracking_enter(enum ctx_state state); > extern void context_tracking_exit(enum ctx_state state); > @@ -38,13 +38,13 @@ static inline void user_exit(void) > static __always_inline void user_enter_irqoff(void) > { > if (context_tracking_enabled()) > - __context_tracking_enter(CONTEXT_USER); > + __ct_user_enter(CONTEXT_USER); > > } > static __always_inline void user_exit_irqoff(void) > { > if (context_tracking_enabled()) > - __context_tracking_exit(CONTEXT_USER); > + __ct_user_exit(CONTEXT_USER); > } > > static inline enum ctx_state exception_enter(void) > @@ -74,7 +74,7 @@ static inline void exception_exit(enum ctx_state prev_ctx) > static __always_inline bool context_tracking_guest_enter(void) > { > if (context_tracking_enabled()) > - __context_tracking_enter(CONTEXT_GUEST); > + __ct_user_enter(CONTEXT_GUEST); > > return context_tracking_enabled_this_cpu(); > } > @@ -82,7 +82,7 @@ static __always_inline bool context_tracking_guest_enter(void) > static __always_inline void context_tracking_guest_exit(void) > { > if (context_tracking_enabled()) > - __context_tracking_exit(CONTEXT_GUEST); > + __ct_user_exit(CONTEXT_GUEST); > } > > /** > diff --git a/kernel/context_tracking.c b/kernel/context_tracking.c > index 36a98c48aedc..ad2a973393a6 100644 > --- a/kernel/context_tracking.c > +++ b/kernel/context_tracking.c > @@ -51,15 +51,15 @@ static __always_inline void context_tracking_recursion_exit(void) > } > > /** > - * context_tracking_enter - Inform the context tracking that the CPU is going > - * enter user or guest space mode. > + * __ct_user_enter - Inform the context tracking that the CPU is going > + * to enter user or guest space mode. > * > * This function must be called right before we switch from the kernel > * to user or guest space, when it's guaranteed the remaining kernel > * instructions to execute won't use any RCU read side critical section > * because this function sets RCU in extended quiescent state. > */ > -void noinstr __context_tracking_enter(enum ctx_state state) > +void noinstr __ct_user_enter(enum ctx_state state) > { > /* Kernel threads aren't supposed to go to userspace */ > WARN_ON_ONCE(!current->mm); > @@ -101,7 +101,7 @@ void noinstr __context_tracking_enter(enum ctx_state state) > } > context_tracking_recursion_exit(); > } > -EXPORT_SYMBOL_GPL(__context_tracking_enter); > +EXPORT_SYMBOL_GPL(__ct_user_enter); > > void context_tracking_enter(enum ctx_state state) > { > @@ -119,7 +119,7 @@ void context_tracking_enter(enum ctx_state state) > return; > > local_irq_save(flags); > - __context_tracking_enter(state); > + __ct_user_enter(state); > local_irq_restore(flags); > } > NOKPROBE_SYMBOL(context_tracking_enter); > @@ -132,8 +132,8 @@ void context_tracking_user_enter(void) > NOKPROBE_SYMBOL(context_tracking_user_enter); > > /** > - * context_tracking_exit - Inform the context tracking that the CPU is > - * exiting user or guest mode and entering the kernel. > + * __ct_user_exit - Inform the context tracking that the CPU is > + * exiting user or guest mode and entering the kernel. > * > * This function must be called after we entered the kernel from user or > * guest space before any use of RCU read side critical section. This > @@ -143,7 +143,7 @@ NOKPROBE_SYMBOL(context_tracking_user_enter); > * This call supports re-entrancy. This way it can be called from any exception > * handler without needing to know if we came from userspace or not. > */ > -void noinstr __context_tracking_exit(enum ctx_state state) > +void noinstr __ct_user_exit(enum ctx_state state) > { > if (!context_tracking_recursion_enter()) > return; > @@ -166,7 +166,7 @@ void noinstr __context_tracking_exit(enum ctx_state state) > } > context_tracking_recursion_exit(); > } > -EXPORT_SYMBOL_GPL(__context_tracking_exit); > +EXPORT_SYMBOL_GPL(__ct_user_exit); > > void context_tracking_exit(enum ctx_state state) > { > @@ -176,7 +176,7 @@ void context_tracking_exit(enum ctx_state state) > return; > > local_irq_save(flags); > - __context_tracking_exit(state); > + __ct_user_exit(state); > local_irq_restore(flags); > } > NOKPROBE_SYMBOL(context_tracking_exit); > -- > 2.25.1 >