From: James Hilliard <james.hilliard1@gmail.com>
To: linux-media@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Pawel Osciak <posciak@chromium.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
James Hilliard <james.hilliard1@gmail.com>
Subject: [PATCH 1/1] uvcvideo: Add support for UVC1.5 P&C control.
Date: Thu, 10 Mar 2022 15:09:40 -0700 [thread overview]
Message-ID: <20220310220940.2994075-1-james.hilliard1@gmail.com> (raw)
From: Pawel Osciak <posciak@chromium.org>
Add support for UVC 1.5 Probe & Commit control.
Signed-off-by: Pawel Osciak <posciak@chromium.org>
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
drivers/media/usb/uvc/uvc_video.c | 34 +++++++++++++++++++++++++++++++
include/uapi/linux/usb/video.h | 7 +++++++
2 files changed, 41 insertions(+)
diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c
index 1b4cc934109e..46b8396e0d3b 100644
--- a/drivers/media/usb/uvc/uvc_video.c
+++ b/drivers/media/usb/uvc/uvc_video.c
@@ -253,6 +253,7 @@ static int uvc_get_video_ctrl(struct uvc_streaming *stream,
u16 size = uvc_video_ctrl_size(stream);
u8 *data;
int ret;
+ unsigned int i;
if ((stream->dev->quirks & UVC_QUIRK_PROBE_DEF) &&
query == UVC_GET_DEF)
@@ -322,6 +323,26 @@ static int uvc_get_video_ctrl(struct uvc_streaming *stream,
ctrl->bMaxVersion = 0;
}
+ if (size >= 48) {
+ ctrl->bUsage = data[34];
+ ctrl->bBitDepthLuma = data[35];
+ ctrl->bmSetting = data[36];
+ ctrl->bMaxNumberOfRefFramesPlus1 = data[37];
+ ctrl->bmRateControlModes = get_unaligned_le16(&data[38]);
+ for (i = 0; i < ARRAY_SIZE(ctrl->bmLayoutPerStream); ++i) {
+ ctrl->bmLayoutPerStream[i] =
+ get_unaligned_le16(&data[40 + i * 2]);
+ }
+ } else {
+ ctrl->bUsage = 0;
+ ctrl->bBitDepthLuma = 0;
+ ctrl->bmSetting = 0;
+ ctrl->bMaxNumberOfRefFramesPlus1 = 0;
+ ctrl->bmRateControlModes = 0;
+ for (i = 0; i < ARRAY_SIZE(ctrl->bmLayoutPerStream); ++i)
+ ctrl->bmLayoutPerStream[i] = 0;
+ }
+
/* Some broken devices return null or wrong dwMaxVideoFrameSize and
* dwMaxPayloadTransferSize fields. Try to get the value from the
* format and frame descriptors.
@@ -340,6 +361,7 @@ static int uvc_set_video_ctrl(struct uvc_streaming *stream,
u16 size = uvc_video_ctrl_size(stream);
u8 *data;
int ret;
+ unsigned int i;
data = kzalloc(size, GFP_KERNEL);
if (data == NULL)
@@ -365,6 +387,18 @@ static int uvc_set_video_ctrl(struct uvc_streaming *stream,
data[33] = ctrl->bMaxVersion;
}
+ if (size >= 48) {
+ data[34] = ctrl->bUsage;
+ data[35] = ctrl->bBitDepthLuma;
+ data[36] = ctrl->bmSetting;
+ data[37] = ctrl->bMaxNumberOfRefFramesPlus1;
+ *(__le16 *)&data[38] = cpu_to_le16(ctrl->bmRateControlModes);
+ for (i = 0; i < ARRAY_SIZE(ctrl->bmLayoutPerStream); ++i) {
+ *(__le16 *)&data[40 + i * 2] =
+ cpu_to_le16(ctrl->bmLayoutPerStream[i]);
+ }
+ }
+
ret = __uvc_query_ctrl(stream->dev, UVC_SET_CUR, 0, stream->intfnum,
probe ? UVC_VS_PROBE_CONTROL : UVC_VS_COMMIT_CONTROL, data,
size, uvc_timeout_param);
diff --git a/include/uapi/linux/usb/video.h b/include/uapi/linux/usb/video.h
index bfdae12cdacf..a0de60efd73c 100644
--- a/include/uapi/linux/usb/video.h
+++ b/include/uapi/linux/usb/video.h
@@ -435,6 +435,7 @@ struct uvc_color_matching_descriptor {
#define UVC_DT_COLOR_MATCHING_SIZE 6
/* 4.3.1.1. Video Probe and Commit Controls */
+#define UVC_NUM_SIMULCAST_STREAMS 4
struct uvc_streaming_control {
__u16 bmHint;
__u8 bFormatIndex;
@@ -452,6 +453,12 @@ struct uvc_streaming_control {
__u8 bPreferedVersion;
__u8 bMinVersion;
__u8 bMaxVersion;
+ __u8 bUsage;
+ __u8 bBitDepthLuma;
+ __u8 bmSetting;
+ __u8 bMaxNumberOfRefFramesPlus1;
+ __u16 bmRateControlModes;
+ __u16 bmLayoutPerStream[UVC_NUM_SIMULCAST_STREAMS];
} __attribute__((__packed__));
/* Uncompressed Payload - 3.1.1. Uncompressed Video Format Descriptor */
--
2.25.1
reply other threads:[~2022-03-10 22:10 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220310220940.2994075-1-james.hilliard1@gmail.com \
--to=james.hilliard1@gmail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=posciak@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®